Skip to content

feat(contracts): add creator key tipping escrow - #1164

Open
kehindeafolabi006-creator wants to merge 2 commits into
accesslayerorg:mainfrom
kehindeafolabi006-creator:fix/issue-1140
Open

kehindeafolabi006-creator wants to merge 2 commits into
accesslayerorg:mainfrom
kehindeafolabi006-creator:fix/issue-1140

Conversation

@kehindeafolabi006-creator

Copy link
Copy Markdown

Adds an initialized key tipping contract with creator registration, 2% protocol fee transfers, receipt history, totals, and a TipSent event.

Closes #1140

Verification: cargo test -p key-tipping passed.

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@kehindeafolabi006-creator Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@kehindeafolabi006-creator

Copy link
Copy Markdown
Author

@accesslayerorg I updated this branch from main and resolved the merge conflicts. Please review and merge when ready.

@Chucks1093

Copy link
Copy Markdown
Member

✅ PR Ready for Review

Due to a recent malware incident affecting our repositories, all PRs are required to pass automated security checks before being reviewed for merging.

This PR has passed all automated checks:

  • ✅ Security scan — no malicious code detected
  • ✅ No merge conflicts
  • ✅ CI checks passed

Next step: Please share this PR link in our Telegram group so a maintainer can review and merge it: https://t.me/c/accesslayerorg/8514

1 similar comment
@Chucks1093

Copy link
Copy Markdown
Member

✅ PR Ready for Review

Due to a recent malware incident affecting our repositories, all PRs are required to pass automated security checks before being reviewed for merging.

This PR has passed all automated checks:

  • ✅ Security scan — no malicious code detected
  • ✅ No merge conflicts
  • ✅ CI checks passed

Next step: Please share this PR link in our Telegram group so a maintainer can review and merge it: https://t.me/c/accesslayerorg/8514

@Chucks1093

Copy link
Copy Markdown
Member

⚠️ Merge Conflict Detected

This PR currently has a merge conflict and cannot be merged until it is resolved.

Please rebase or merge the latest changes from the base branch into your branch and push again.

@kehindeafolabi006-creator

Copy link
Copy Markdown
Author

Note for maintainers: the merge conflict in Cargo.toml is resolved, and key-tipping tests pass (3/3). The title says holder-to-creator, but send_tip routes tips through the contract (tipper to contract to creator). So the contract holds funds briefly, and set_creator is admin-only. Please confirm this is intended, or update the title and description.

@zeemscript

Copy link
Copy Markdown
Contributor

@Chucks1093 Synced this PR with the latest main, resolving the duplicate Soroban error-code conflict. Local validation: cargo test -p key-tipping passed (3 tests). Fresh GitHub verify check is queued; please review once it completes.

@Chucks1093

Copy link
Copy Markdown
Member

✅ PR Ready for Review

Due to a recent malware incident affecting our repositories, all PRs are required to pass automated security checks before being reviewed for merging.

This PR has passed all automated checks:

  • ✅ Security scan — no malicious code detected
  • ✅ No merge conflicts
  • ✅ CI checks passed

Next step: Please share this PR link in our Telegram group so a maintainer can review and merge it: https://t.me/c/accesslayerorg/8514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add key creator tipping contract for direct holder-to-creator payments

3 participants