Fix: 'contract' relationship not populated on emitted events - #171
Open
devanshi00 wants to merge 2 commits into
Open
Fix: 'contract' relationship not populated on emitted events#171devanshi00 wants to merge 2 commits into
devanshi00 wants to merge 2 commits into
Conversation
Signed-off-by: “Devanshi <117909426+devanshi00@users.noreply.github.com>
Signed-off-by: “Devanshi <117909426+devanshi00@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.accordproject.cicero.runtime.Obligationdeclares a required relationship back to the governing contract:Any event emitted by a template needs to extend
Obligation(e.g.PaymentObligationEvent), thereby inheriting this requiredcontractfield, causing:Changes Made
Based on @mttrbrts opinion
populateObligationBackReferences(events, data)inTemplateArchiveProcessor.trigger(), invoked immediately before the existing event-validation loop.contractis already set (template logic can still set it explicitly)Obligationandcontractis unset, anddata(the contract/clause instance passed intotrigger()) itself extendsContract, look updata's identifying field viamodelManager.getType(data.$class).getIdentifierFieldName()and build the relationship as a"<identifierValue>"string — the correct serialized form for a relationship field than assigning the resource itself.datadoes not extendContract, or its identifier can't be resolved, throw a clear error naming the offending event instead of letting the opaqueValidationExceptionsurface fromresourcevalidator.js.RUNTIME_OBLIGATION_FQN(org.accordproject.runtime@0.2.0.Obligation) andRUNTIME_CONTRACT_FQN(org.accordproject.contract@0.2.0.Contract) constants toutils.ts.Fixes bug
#170
@mttrbrts @dselman @DianaLease