[login] Fix reset password bug in French (non-ASCII characters) - #11055
Open
HachemJ wants to merge 1 commit into
Open
[login] Fix reset password bug in French (non-ASCII characters)#11055HachemJ wants to merge 1 commit into
HachemJ wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes the multilingual password reset bug described in the issue, where users could not receive password reset emails when their language preference was set to French. The problem was caused by the email subject containing non-ASCII characters without being properly encoded. Since the subject is an email header, it must be encoded before being passed to the mail() function (at the end of
Email.class.inc). This PR fixes the issue by encoding the subject usingmb_encode_mimeheader()before sending the email.Testing instructions (if applicable)
Prerequisite: Ensure the user account being tested has a valid email address configured. If necessary, update the user's email in the database:
Link(s) to related issue(s)