Skip to content

[login] Fix reset password bug in French (non-ASCII characters) - #11055

Open
HachemJ wants to merge 1 commit into
aces:29.0-releasefrom
HachemJ:FixCannotResetPasswordWhenLanguageIsFrench
Open

[login] Fix reset password bug in French (non-ASCII characters)#11055
HachemJ wants to merge 1 commit into
aces:29.0-releasefrom
HachemJ:FixCannotResetPasswordWhenLanguageIsFrench

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR fixes the multilingual password reset bug described in the issue, where users could not receive password reset emails when their language preference was set to French. The problem was caused by the email subject containing non-ASCII characters without being properly encoded. Since the subject is an email header, it must be encoded before being passed to the mail() function (at the end of Email.class.inc). This PR fixes the issue by encoding the subject using mb_encode_mimeheader() before sending the email.

Testing instructions (if applicable)

  1. Please follow the instructions described in the corresponding issue.

Prerequisite: Ensure the user account being tested has a valid email address configured. If necessary, update the user's email in the database:

UPDATE users
SET Email = 'user@example.com'
WHERE UserID = 'username';

Link(s) to related issue(s)

@github-actions github-actions Bot added the Language: PHP PR or issue that update PHP code label Jul 27, 2026
@HachemJ HachemJ added Critical to release PR or issue is key for the release to which it has been assigned Multilingual Any tasks related to making LORIS multilingual 29.0.0 - Bugs Issues found during the release testing for 29.0.0 labels Jul 27, 2026
@HachemJ HachemJ changed the title [login] Fix multilingual reset password bug [login] Fix reset password bug in French (non-ASCII characters) Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Critical to release PR or issue is key for the release to which it has been assigned Language: PHP PR or issue that update PHP code Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants