Skip to content

Harden testing, evidence, UI, and safety controls - #4

Merged
acutedev merged 18 commits into
mainfrom
dev/testing-hardening
Jul 12, 2026
Merged

acutedev merged 18 commits into
mainfrom
dev/testing-hardening

Conversation

@acutedev

Copy link
Copy Markdown
Owner

No description provided.

acutedev and others added 17 commits July 8, 2026 20:42
The Submitter/Auditor "Deterministic Router · final authority" callout
showed "Auto-approved" for human-approved-then-paid invoices (e.g.
INV-1003). The /submissions/{id} projection dropped the router's route
and the human review_status, so the UI inferred the outcome by
elimination and fell through to an auto-approve fallback — misrepresenting
the deterministic-authority boundary on the compliance view.

Surface recorded facts instead of guessing:
- add `route` to DECISION_PRESENTATION_FIELDS so the router's decision
  persists on the workflow record and appears in the status/audit projection
- include `review_status` in the /submissions/{id} response
- UI shows two recorded facts — "Routed to" (router's binding lane) and
  "Authorized by" (human approval, autonomous router, or none); the
  guess-by-elimination auto-approve fallback is removed

Covered by test_submissions.py::*_surfaces_route_*; verified live
(LLM_PROVIDER=stub) with re-captured INV-1003 submitter/auditor evidence.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
demo Compose), bind NGINX to 127.0.0.1:8080, and stop /api/smoke/secret from
returning the Dapr secret value.
Copilot AI review requested due to automatic review settings July 12, 2026 12:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@acutedev
acutedev merged commit 5a70065 into main Jul 12, 2026
4 checks passed
@acutedev
acutedev deleted the dev/testing-hardening branch July 14, 2026 03:03
acutedev added a commit that referenced this pull request Aug 4, 2026
Harden testing, evidence, UI, and safety controls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants