Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43.
The problem
Many functions and methods in
adafruit_framebuf.pyhave no type annotations, so mypy reports them as missing annotations.The change
from typing import Any, Optional, Tuple, Unionintry/except ImportError, becausetypingdoes not exist on CircuitPython.FrameBufferis a string, and annotations are not evaluated on CircuitPython.deflines and the import block are touched.Testing
Added
tests/test_annotations.py, which usesinspectto check that every function and method in the module has a return annotation and annotated parameters. After the change, it passes:Regression test:
tests/test_annotations.pychecks the annotations added by this change.Fixes #43