Repository navigation
V2 Move pin components to digitalio and analogio - #343
Merged
Merged
Conversation
tyeth
reviewed
Sep 23, 2026
tyeth
left a comment
Member
There was a problem hiding this comment.
would make a bit more sense with a git mv to show the renamed / moved files, then amend them, as not easy to compare with v1 in this diff.
| strategy: | ||
| matrix: | ||
| componentType: [pin, i2c, i2c_output, servo, ds18x20, pwm, pixel, uart, display, expanders] | ||
| componentType: [pin, digitalio, analogio, i2c, i2c_output, servo, ds18x20, pwm, pixel, uart, display, expanders] |
brentru
reviewed
Sep 23, 2026
|
|
||
| # folks with write access to the repo (Adafruit team) can change more sensitive files | ||
| INTERNAL_REGEX="^(\.github\/.*|components\/(sensors.json|(pin|i2c|servo|ds18x20|pwm|pixel|uart|i2c_output|display|expanders)\/(schema.json|.*\/(definition\.json|image\.(png|jpe?g|gif)))))$" | ||
| INTERNAL_REGEX="^(\.github\/.*|components\/(sensors.json|(pin|digitalio|analogio|i2c|servo|ds18x20|pwm|pixel|uart|i2c_output|display|expanders)\/(schema.json|.*\/(definition\.json|image\.(png|jpe?g|gif)))))$" |
Member
Author
|
@tyeth @brentru you both asked why keeping the
Honestly that might not be true as I think about it... just sorta working publicly while i get backend imports and multi-version usage on the frontend working. I bet you end up being correct and we actually do remove pins before this hits prod. Stay tuned. |
Member
Author
|
i ended up deleting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V1 "pin components" get broken out into digital and analog components for V2.
This PR:
pin/*into:digitalio/*whenmode: "DIGITAL"analogio/*whenmode: "ANALOG"pin/schema.jsontodigitalio/andanalogio/mode(implicit by directory)selectReadMode&analogReadModemodeselectPullUp&pulldigitalioandanalogiochecks to gh:avalidate.yml