Skip to content

Add Raspberry Pi Touch Display 2 (7") - first MIPI DSI display - #348

Draft
tyeth wants to merge 3 commits into
v2-displaysfrom
add/display-dsi-rpi-td2-7in
Draft

tyeth wants to merge 3 commits into
v2-displaysfrom
add/display-dsi-rpi-td2-7in

Conversation

@tyeth

@tyeth tyeth commented Nov 3, 2026

Copy link
Copy Markdown
Member

Adds the first DSI display definition and the schema pieces it needs.

Definition — components/display/tft/ili9881c/720x1280/adafruit-6079/definition.json

  • Raspberry Pi Touch Display 2, 7" (Adafruit 6079), driver ILI9881C, panel rpi-touch-display-2-7in
  • dsi: { bus: 0 }, native 720x1280 shown landscape (rotation: 1), textSize: 5
  • Brightness as user-selectable levels (Lowest 2 → Maximum 31 of 31, default Low = 4, safe on USB-only power)
  • published: false until the firmware DSI support ships (Metro ESP32-P4)
  • The 5" Touch Display 2 (Adafruit 6408) is the same panel family and could follow as a sibling once tested.

Schema (components/display/schema.json)

  • displayType.dsi → ws.display.DsiInterfaceDescriptor (bus, optional pinRst; the Touch Display 2 resets via its own controller so it's omitted)
  • displayType.backlight → ws.display.BacklightConfig.backlight_pwm: resolution + brightness (displayName/description/default/options). Unlike the I2C settings (which send an option index), each option carries the dutyCycle sent as backlight_pwm.write.duty_cycle, so the broker can build the proto directly. No pin is needed for panels whose backlight is set by their own controller; firmware scales duty by resolution onto the panel's 0–31 steps.

Protobuf — no changes needed: everything maps onto Wippersnapper_Protobuf api-v2 (display.proto unchanged since b3688d6): Add.interface_type.dsi (tag 7), panel (4), config_display DisplayProperties (9), backlight (11), Write (B2D tag 3).

Tested on hardware (Metro ESP32-P4 + Touch Display 2) via protoMQ with:

{"display":{"add":{"name":"td2","type":"DISPLAY_CLASS_TFT","driver":"ILI9881C","panel":"rpi-touch-display-2-7in","interfaceType":{"dsi":{"bus":0}},"configDisplay":{"width":1280,"height":720,"rotation":1,"textSize":5,"statusBar":true},"backlight":{"backlightPwm":{"pin":"","resolution":5,"write":{"pin":"","dutyCycle":4}}}}}}

Note: the schema's tftConfig has no statusBar (same as the other TFTs), so the status bar falls back to whatever the broker/firmware default is.

All 28 display definitions validate locally against the updated schema (jsonschema draft-07).

🤖 Generated with Claude Code

- components/display/tft/ili9881c/720x1280/adafruit-6079: ILI9881C, panel
  "rpi-touch-display-2-7in", DSI bus 0, 720x1280 native shown landscape
  (rotation 1), text size 5, unpublished until firmware DSI support ships.
- schema: add the `dsi` interface (ws.display.DsiInterfaceDescriptor: bus,
  optional pinRst) and a `backlight` block (ws.display.BacklightConfig
  backlight_pwm): PWM resolution plus user-selectable brightness options,
  each sending its dutyCycle as backlight_pwm.write.duty_cycle. The Touch
  Display 2 uses resolution 5 (its controller's 0-31 steps), default Low (4)
  which is safe on USB-only power.

Matches Wippersnapper_Protobuf api-v2 (display.proto unchanged since
b3688d6); hardware-tested on an Adafruit Metro ESP32-P4 via protoMQ.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tyeth tyeth self-assigned this Nov 3, 2026
The 9b725c2 pin fails the Validate Image Dimensions job; main already uses
7bcb45380be40873a59cc0d4a457ec9228b6c84c (upstream 'Rollback some upgrades').

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dislike the adafruit-6079 in path, too long, unnecessary, although maybe useful search field etc, and strictly speaking I asked for it or similar in #304

@@ -0,0 +1,38 @@
{
"displayName": "Pi Touch Display 2 7\"",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7" wasn't seen in io-rails picker, just 7. Double check others, there was a 3.7" display shown so speechmarks should be possible

@tyeth tyeth left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant