Skip to content

Add/display dsi rpi td2 7in flat - #350

Draft
tyeth wants to merge 20 commits into
mainfrom
add/display-dsi-rpi-td2-7in-flat
Draft

tyeth wants to merge 20 commits into
mainfrom
add/display-dsi-rpi-td2-7in-flat

Conversation

@tyeth

@tyeth tyeth commented Nov 3, 2026

Copy link
Copy Markdown
Member

No description provided.

tyeth and others added 18 commits October 21, 2025 13:52
…archy

Move display components from flat naming (e.g. eink-29-grayscale-ssd1680/)
to nested hierarchy: {class}/{driver}/{WxH}/{mode}/ aligned with
Wippersnapper_Protobuf PR #170 unified display.proto.

Folder convention: components/display/{class}/{driver}/{resolution}/{mode}/
- EPD: epd/{driver}/{WxH}/{mode}/ (e.g. epd/ssd1680/296x128/mono/)
- TFT: tft/{driver}/{WxH}/ (e.g. tft/st7789/240x135/)
- OLED: oled/{driver}/{WxH}/ (e.g. oled/ssd1306/128x64/)
- LED Backpack: led_backpack/{driver}/{panel}/ (e.g. led_backpack/ht16k33/4digit-7seg/)
- Char LCD: char_lcd/{driver}/{RxC}/ (e.g. char_lcd/mcp23008/16x2/)

Schema changes:
- driver field: enum -> free-form string (bare uppercase e.g. "SSD1680")
- type enum: added oled, led_backpack, char_lcd
- Added panel field for same-driver disambiguation
- Added i2c config with addresses array (hex strings)
- Added displayConfig, ledBackpackConfig, charLcdConfig blocks

New components (migrated from i2c_output + proto driver list):
- OLED: SSD1306 (128x64, 128x32, 64x32), SSD1305, SSD1327, SH1106, SH1107 (128x64, 128x128)
- LED Backpack: HT16K33 (7-segment, quad alphanumeric)
- Char LCD: MCP23008 (16x2, 20x4), PCF8574 (16x2)
- EPD: SSD1680 2.13" panel variants (pre2024, rev2024)

Total: 24 display components across 5 classes (was 9 EPD/TFT only).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ct entries

Each Adafruit product ID gets its own component entry. OLEDs now use
{class}/{driver}/{WxH}/{product-id}/ to distinguish products that share
the same driver and resolution.

Key fix: SSD1306 128x32 split into two entries:
- adafruit-4440 (breakout, addresses 0x3C/0x3D)
- adafruit-2900 (FeatherWing, address 0x3C only)

All OLEDs now have product-level subfolders:
- oled/ssd1306/128x64/adafruit-938/
- oled/ssd1306/128x32/adafruit-4440/
- oled/ssd1306/128x32/adafruit-2900/
- oled/ssd1306/64x32/generic-midas/
- oled/ssd1305/128x64/adafruit-2720/
- oled/sh1106/128x64/adafruit-5297/
- oled/sh1107/128x64/adafruit-4650/
- oled/sh1107/128x128/adafruit-5297/
- oled/ssd1327/128x128/adafruit-4741/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove i2c_output from validation matrix (superseded by display/)
- Change definition.json glob from */ to **/ to match nested display paths
- Remove i2c_output from filename validation regexes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add oldNames array to all display definitions that have v1 equivalents,
mapping old folder names from display/ (EPD/TFT) and i2c_output/
(OLED/LED backpack/char LCD) to the new nested structure.

OLED entries map to both text size variants (e.g. oled128x64default +
oled128x64large) since v2 handles text_size as a configurable property.

Schema updated with optional oldNames string array field.

5 new-only components correctly have no oldNames:
- char_lcd/pcf8574/16x2 (proto-only, no v1 product)
- epd/ssd1680/250x122/mono/pre2024 and rev2024 (new panel variants)
- oled/sh1106 and oled/ssd1305 (proto-only, no v1 i2c_output entry)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add 2.2inch 320x240 ILI9431 SPI TFT (PID 1480)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add 1.8" 128x160 ST7735R SPI TFT (PID 358)
- components/display/tft/ili9881c/720x1280/adafruit-6079: ILI9881C, panel
  "rpi-touch-display-2-7in", DSI bus 0, 720x1280 native shown landscape
  (rotation 1), text size 5, unpublished until firmware DSI support ships.
- schema: add the `dsi` interface (ws.display.DsiInterfaceDescriptor: bus,
  optional pinRst) and a `backlight` block (ws.display.BacklightConfig
  backlight_pwm): PWM resolution plus user-selectable brightness options,
  each sending its dutyCycle as backlight_pwm.write.duty_cycle. The Touch
  Display 2 uses resolution 5 (its controller's 0-31 steps), default Low (4)
  which is safe on USB-only power.

Matches Wippersnapper_Protobuf api-v2 (display.proto unchanged since
b3688d6); hardware-tested on an Adafruit Metro ESP32-P4 via protoMQ.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 9b725c2 pin fails the Validate Image Dimensions job; main already uses
7bcb45380be40873a59cc0d4a457ec9228b6c84c (upstream 'Rollback some upgrades').

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The staging importer reads components/display/<name>/definition.json one
level deep, so the nested class/driver/resolution/product layout imports
as five unparseable 'components' (char_lcd, epd, led_backpack, oled, tft).
Move each definition to a flat folder, reusing the names main/staging
already know where the display is clearly the same (tft-114, eink-magtag,
oled128x32default, 7seg, chardisplay16x2, ...) so those import as changes
rather than orphan + creation. Contents unchanged; 28 definitions validate
against components/display/schema.json.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tyeth
tyeth marked this pull request as draft November 3, 2026 12:41
tyeth and others added 2 commits November 3, 2026 13:03
Resolve validate.yml to main (digital/analog/i2c_output/expander matrix,
checkout@v7, setup-imagemagick 7bcb453). v2 moves the i2c_output displays
into display/, so carry their product images into the matching flat
display folders (7seg, chardisplay16x2/20x4, oled128x32/64x32/128x64default,
quadalphanum).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v2 moves the i2c_output displays into components/display/, so the
category (and its schema) no longer exists on this branch and the matrix
job failed with ENOENT on components/i2c_output/schema.json, cancelling
the rest of the fail-fast matrix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant