Skip to content

fix(ADS7128): remove pull options, label pins A0-A7 - #352

Open
tyeth wants to merge 1 commit into
mainfrom
ads7128-no-pulls
Open

tyeth wants to merge 1 commit into
mainfrom
ads7128-no-pulls

Conversation

@tyeth

@tyeth tyeth commented Nov 4, 2026

Copy link
Copy Markdown
Member

Corrects the ADS7128 expander definition (https://www.adafruit.com/product/6494):

  • Removes hasPullup / hasPulldown from all 8 pins. The learn guide's Pinouts page says: "The ADS7128 has no internal pull resistors, so you will want to add a pull-up or pull-down resistor when using a pin as an digital input." The Adafruit_ADS7128 library also has no pull API: its pin modes are only analog, input, output, and open-drain output. These flags were added in 3a2ed21.
  • Renames pin labels AIN0–AIN7 to A0–A7, to match the board silkscreen and guide. Pin name values (0–7) are unchanged.

i2cAddresses (0x10–0x17, set by ADDR resistor or jumper) matches the guide. published stays false until firmware support ships. The WipperSnapper v2 firmware driver is in adafruit/Adafruit_Wippersnapper_Arduino (drv_ads7128.h, stacked on the pull-down work).

🤖 Generated with Claude Code

The ADS7128 has no internal pull resistors (learn guide, Pinouts:
https://learn.adafruit.com/adafruit-ads7128-8-channel-adc-and-gpio-expander/pinouts),
so drop hasPullup/hasPulldown from every pin. Pin labels match the
board silkscreen (A0-A7).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tyeth tyeth self-assigned this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant