Repository navigation
Conversation
The ADS7128 has no internal pull resistors (learn guide, Pinouts: https://learn.adafruit.com/adafruit-ads7128-8-channel-adc-and-gpio-expander/pinouts), so drop hasPullup/hasPulldown from every pin. Pin labels match the board silkscreen (A0-A7). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the ADS7128 expander definition (https://www.adafruit.com/product/6494):
hasPullup/hasPulldownfrom all 8 pins. The learn guide's Pinouts page says: "The ADS7128 has no internal pull resistors, so you will want to add a pull-up or pull-down resistor when using a pin as an digital input." The Adafruit_ADS7128 library also has no pull API: its pin modes are only analog, input, output, and open-drain output. These flags were added in 3a2ed21.AIN0–AIN7toA0–A7, to match the board silkscreen and guide. Pinnamevalues (0–7) are unchanged.i2cAddresses(0x10–0x17, set by ADDR resistor or jumper) matches the guide.publishedstaysfalseuntil firmware support ships. The WipperSnapper v2 firmware driver is in adafruit/Adafruit_Wippersnapper_Arduino (drv_ads7128.h, stacked on the pull-down work).🤖 Generated with Claude Code