Skip to content

(i2c, uart) Sync with sensor.proto Type enum - #353

Merged
brentru merged 2 commits into
mainfrom
add-sensor-type-enum
Nov 5, 2026
Merged

brentru merged 2 commits into
mainfrom
add-sensor-type-enum

Conversation

@brentru

@brentru brentru commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

This pull request:

  • Adds a typeEnum field for each sensor type to reflect the sensor.proto API's type enum.
  • Extends components/sensors.json (and related uart/i2c schema.json files) with two new types - bytes and boolean`.
  • Removed unused sensor type, unspecified, from the allowed values in the I2C schema and documentation.
  • Allows Adafruit to modify README.md documentation and .agents/ workflows

@brentru
brentru requested review from lorennorman and tyeth November 5, 2026 18:30
Adds README.md and .agents/ to INTERNAL_REGEX so Adafruit team PRs
that update docs or agent skills pass the expected-filenames check,
and exempts them from the lowercase-only filename rule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@lorennorman lorennorman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

I don't see any reason it shouldn't go to main, there is no longer a v2 PR unto itself, v1 and v2 were unified. We only need individual branches/PRs for things that will break prod now. (like v2-displays, etc)

@brentru
brentru changed the base branch from v2 to main November 5, 2026 18:39
@brentru

brentru commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@lorennorman Ok, changed the base to main

@brentru
brentru merged commit c6d677c into main Nov 5, 2026
17 checks passed
@brentru
brentru deleted the add-sensor-type-enum branch November 5, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants