Repository navigation
(i2c, uart) Sync with sensor.proto Type enum - #353
Merged
Merged
Conversation
Adds README.md and .agents/ to INTERNAL_REGEX so Adafruit team PRs that update docs or agent skills pass the expected-filenames check, and exempts them from the lowercase-only filename rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lorennorman
approved these changes
Nov 5, 2026
lorennorman
left a comment
Member
There was a problem hiding this comment.
This looks good.
I don't see any reason it shouldn't go to main, there is no longer a v2 PR unto itself, v1 and v2 were unified. We only need individual branches/PRs for things that will break prod now. (like v2-displays, etc)
Member
Author
|
@lorennorman Ok, changed the base to |
tyeth
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request:
typeEnumfield for each sensor type to reflect the sensor.proto API's type enum.components/sensors.json(and related uart/i2cschema.jsonfiles) with two new types -bytesand boolean`.unspecified, from the allowed values in the I2C schema and documentation.README.mddocumentation and.agents/workflows