fix(protocol): support AdCP 3.1.14 schemas - #1026
Merged
Merged
Conversation
bokelley
marked this pull request as ready for review
August 16, 2026 18:55
bokelley
enabled auto-merge (squash)
August 16, 2026 18:55
Contributor
|
The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final This is an automated message from the Argus AI review workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
measurement,promotion, andlinear_tvvaluesWhy
AdCP 3.1.14 is a schema-correction release that replaces three inline enum copies with their canonical definitions. The generated 7.0 changelog also split user-facing SDK changes across three release candidates and the stable release. This PR keeps the 7.x line current with the latest stable AdCP 3.1 patch and gives adopters one complete migration page to follow.
Developer impact
Adopters upgrading from any SDK 6.x release now have explicit instructions for:
The schema update additionally accepts:
measurementas a registry badge protocol rolepromotionas a sponsored-placement catalog typelinear_tvas a trusted-match surfaceValidation
32 passedacross the 3.1.14 regressions, schema-version pin, signing-vector completeness, and code-generation tests6383 passed, 41 skipped, 1 xfailed; one unrelated wall-clock benchmark exceeded its five-second budget under load, then passed in isolationmake validate-generatedruff check tests/test_adcp_3_1_14_schema_backport.pyLegacy*type and verified each documented client methodcreate_roster_account_store, decisioningserve,PgBackend, andIdempotencyStoregit diff --check