Repository navigation
Conversation
Move shared content lifecycle and resolvers to their owners. Expose watch strategies through adnbn/content and keep framework normalization in the selected adapter. Move Relay normalization and content construction into runtime. Replace the old builder contract and update virtual modules, declarations, tests, and documentation.
Prepare data per anchor before creating UI and pass the prepared data, container, and render target to Content and Relay renderers. Keep mount and unmount synchronous, invalidate stale preparation, and retain watching after anchor errors. Cover lifecycle behavior, React portals, headless Relay, and published declarations. BREAKING CHANGE: Render handlers are synchronous; asynchronous work and render decisions belong in prepare. React render functions are components invoked by React. ContentScriptProps now includes data, container, and target; container factories receive ContentScriptContainerProps before those DOM elements exist. ContentScriptWatchStrategy update callbacks may be asynchronous. Literal render: true tracks anchors without UI, while prepare returning false skips UI creation. Consumers checking published declarations require TypeScript 5.6.3 or newer.
Read entrypoint assets and isolated styles through the generated #adnbn/runtime facade. Keep Rspack runtime access in build code and preserve per-entrypoint asset-map selection and isolated CSS delivery. Separate asset collection, filename handling, compilation state and layer classification. Keep isolated-style helpers inside their owning plugin.
Expose typed boundaries in content and Relay render props. Accept a tag, DOM properties or a synchronous factory for isolated render targets, and run boundary setup with an optional cleanup function for subscriptions. Share setup policy through IsolationSetup while the nodes retain DOM, style and cleanup ownership. Preserve synchronous mounting and protect cleanup, remounts and iframe document recovery from reentrant callbacks. Cover the contract with unit, declaration and browser integration tests, and document the current API and lifecycle. BREAKING CHANGE: Remove ContentScriptFrameOptions and isolation.width / isolation.height. Set iframe dimensions and styles through boundary; iframes receive no framework width, height, border or display defaults. ContentScriptProps now includes a required boundary property, and content and Relay definitions carry an isolation type parameter. When specifying data generics explicitly for an isolated entrypoint, specify its mode too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.