Repository navigation
fix(asset): handle Safari URLs and restore CSS ID tokens - #117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari builds emit Chromium resource URLs for
?browserand?chromeassets. Selectsafari-web-extension://for Safari while preservingchrome-extension://for Chromium targets andmoz-extension://for Firefox.Replace the late, all-asset token rewrite with
CssIdTokenPlugin. It restores the native extension ID token only in emitted CSS throughprocessAssetsandReplaceSource, before source map extraction and final content hashing. Both plugins shareCssExtensionIdTokenfromtoken.ts.Validation:
npm run checkpasses, including non-browser tests and fixture builds/typechecks.Safari is verified at build-output level; Safari runtime testing remains outstanding.