Repository navigation
Conversation
Preserve the existing conditional script result type locally so consumers can install newer @types/chrome declarations without TS2694.
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installed
@types/chrome0.3.5 declareschrome.scripting.Awaited, but newer declarations accepted by this package's dependency range remove that alias. Packing this library and installing it into a fresh consumer then fails with TS2694.Keep the existing one-level PromiseLike result transformation as a local conditional type. The public executeScript contract is preserved; consumer checks assert compatibility in both directions.
Validation: isolated source/test typecheck, production build and tree shaking, fresh packed ESM/CJS consumer installation and typecheck. This change is independent of the Safari API adaptations.