Skip to content

feat: support configurable Cloudflare secret key names - #183

Merged
adyanth merged 7 commits into
adyanth:mainfrom
rezzell:codex/configurable-cloudflare-secret-keys
Aug 15, 2026
Merged

feat: support configurable Cloudflare secret key names#183
adyanth merged 7 commits into
adyanth:mainfrom
rezzell:codex/configurable-cloudflare-secret-keys

Conversation

@russell-parks

Copy link
Copy Markdown
Contributor

Summary

  • add camelCase Cloudflare secret key fields (apiTokenKey, apiKeyKey, emailKey) with defaults that preserve current behavior
  • keep the existing uppercase fields as legacy aliases and resolve precedence so old manifests continue to work
  • update controller secret lookup, CRD schemas, tests, and auth docs/examples for configurable secret data keys

Testing

  • GOTOOLCHAIN=go1.24.2 GOCACHE=/private/tmp/cloudflare-operator-go-build GOMODCACHE=/private/tmp/cloudflare-operator-go-mod /opt/homebrew/bin/go test ./api/v1alpha1 ./api/v1alpha2 ./internal/controller -count=1

@russell-parks
russell-parks force-pushed the codex/configurable-cloudflare-secret-keys branch from 3ae27a2 to ea50253 Compare May 24, 2026 20:35
@adyanth

adyanth commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Thanks for the contribution! Could you please run the golangci-linter and fix them please? The PR looks good to me.

@russell-parks

Copy link
Copy Markdown
Contributor Author

Done, thanks. I pushed 99971c2 to wrap the long log line reported by golangci-lint.\n\nLocal validation:\n- make lint -> 0 issues\n- go test ./... -> passed\n\nRemediation checkpoint: CFOP-PR183-LINT-001 against prior head 8111326.

@adyanth
adyanth merged commit b581973 into adyanth:main Aug 15, 2026
4 checks passed
@russell-parks
russell-parks deleted the codex/configurable-cloudflare-secret-keys branch August 19, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants