Skip to content

Clarify missing channel default skill setup - #3629

Open
louis4li wants to merge 3 commits into
feature/integratefrom
fix/2026-09-15_channel-default-skill-missing-guidance
Open

louis4li wants to merge 3 commits into
feature/integratefrom
fix/2026-09-15_channel-default-skill-missing-guidance

Conversation

@louis4li

Copy link
Copy Markdown
Contributor

Issue

Closes #3628

Scope

  • Add channel-default-skill-specific setup guidance when use_skill cannot load the configured skill from Ornn.
  • Preserve default-skill routing behavior: no Ornn search or replacement skill selection for the default binding path.
  • Cover the runner prompt and use_skill not-found result with focused tests.

Verification

  • dotnet test test/Aevatar.GAgents.ChannelRuntime.Tests/Aevatar.GAgents.ChannelRuntime.Tests.csproj --nologo --filter "FullyQualifiedName~ChannelConversationTurnRunnerTests" passed: 167 passed, 0 failed, 0 skipped.
  • dotnet test test/Aevatar.AI.ToolProviders.Ornn.Tests/Aevatar.AI.ToolProviders.Ornn.Tests.csproj --nologo --filter "FullyQualifiedName~LocalSkillCatalogTests" passed: 17 passed, 0 failed, 0 skipped.
  • bash tools/ci/test_stability_guards.sh passed.
  • git diff --check passed.
  • Local NyxID/API endpoint check not run; this change is limited to prompt/tool-result behavior covered by focused unit tests.

Notes

  • Existing restore/build warnings were present during test runs and did not fail verification.

Generated with Claude Code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T04:23:51.552840Z 4e2b661 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e2b66121f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Aevatar.AI.ToolProviders.Skills/UseSkillTool.cs
louis4li and others added 2 commits September 15, 2026 12:47
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant