fix(console): automatically confirm Telegram channel creation - #3650
Open
AbigailDeng wants to merge 1 commit into
Open
AbigailDeng wants to merge 1 commit into
AbigailDeng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Creating a Telegram channel with only a bot token could remain on the submitted form even though provisioning had succeeded. The backend completes Nyx provisioning before returning
accepted, but its local registration list becomes visible asynchronously. The form made only one immediate list read and required a manual Check again after a delayed or failed read. A read-only recheck of the reported channel opened its existing detail page with Active inbound status and Ready delivery status.The form now automatically confirms the exact registration ID, scope and Telegram platform through the existing query, then shows the existing success toast and opens the channel detail page. Pending/error reads retry only GET after one second, with no overlapping reads and a 30-second total limit that includes stalled requests. Accepted creation is never resubmitted. Completion and unmount stop confirmation; late responses cannot navigate or show success. At the limit the submit action remains disabled as Connection pending, with one warning and the existing Back to channels action.
Remove the entire manual Check again panel, its styles and unused English/Chinese messages. Use the existing submit button for Connecting feedback. Token-only name defaults, service grants, API requests and detail presentation remain shared with the existing flow.
Scope and documentation
TelegramConnectionPage.tsxand its integration tests: automatic confirmation, exact ownership checks, duplicate submission protection, timeout and unmount behavior.connectionStyles.tsand channel locale catalogs: remove the manual confirmation surface and localize button feedback.docs/features/2026-09-14-channel-pages.md: document the bounded creation-only confirmation exception to manual browsing refresh.origin/feature/integrateatc74b68f13,NyxTelegramProvisioningService.cs:187. Frontend-only change.Local verification
All frontend commands below ran from
apps/aevatar-console-web/unless noted.python3 /Users/abigaildeng/.codex/skills/frontend-incremental-pr/scripts/frontend_change_scope.py --repo . --base origin/feat/2026-08-04_workflow-activity-vnext.pnpm exec jest --listTests --runInBand --findRelatedTests src/pages/workflow-activity-vnext/channels/TelegramConnectionPage.tsx src/pages/workflow-activity-vnext/channels/connectionStyles.tsselected exactly the 3 files run below. Locale catalogs were excluded from dependency discovery because of their broad import fan-out.pnpm exec jest --runInBand --runTestsByPath src/pages/workflow-activity-vnext/channels/TelegramConnectionPage.test.tsx src/pages/workflow-activity-vnext/channels/ChannelEditPage.test.tsx src/pages/workflow-activity-vnext/index.test.tsxpassed: 3 suites, 154 tests. The initial creation-only run found a test selector that omitted Ant Design's loading icon accessible name; the selector was corrected and all 13 creation tests pass in the final run.pnpm exec biome check src/pages/workflow-activity-vnext/channels/TelegramConnectionPage.tsx src/pages/workflow-activity-vnext/channels/TelegramConnectionPage.test.tsx src/pages/workflow-activity-vnext/channels/connectionStyles.ts src/locales/channelMessages.en-US.ts src/locales/channelMessages.zh-CN.tspassed for all 5 files, after formatting those files with the same scoped Biome command using--write.bash tools/ci/test_stability_guards.shandgit diff --checkpassed.Design baseline