Repository navigation
fix(publish): open no PR for a fix whose issue is already fixed - #174
Merged
Merged
Conversation
A fixed issue was resolved, often by a PR that someone opened by hand. Its GitHub issue is closed. Publish still offered a PR for the issue's own verified fix whenever that fix had no PR recorded, so a patrol would open a duplicate PR for a change that is already on main. The recheck of stored skips in #173 made this more likely, because it can revive a held-back fix. Treat a fixed issue like a dismissed one at the top of the selector, so it owes neither a PR nor an issue. The issue branch already excluded fixed issues, so that duplicate check goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Nebula AI Agent <277912164+nebula-ai-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Bugpatrol review: cliNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
joaquim-verges
added
the
mergepatrol
Nebula AI Agent
Contributor
|
Merged as d24ae17. |
The agent found nothing to fix in the code.
merge-loop
Bot
removed
the
mergepatrol
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A patrol's publish step offered to open a PR for a fix whose issue was already fixed: resolved by a different PR, with its GitHub issue closed. It happens when a verified fix never got a PR recorded, for example after a false skip, and the change then landed by hand. The stored-skip recheck in #173 revives exactly those held-back fixes, so the next real publish would have opened duplicate PRs for changes already on main. A patrol dry run today drafted two such PRs.
Change
runPublishertreats afixedissue like adismissedone at the top of its selector, so it owes neither a PR nor an issue.fixed/dismissedexclusion was then redundant and is removed.Verification
fixedwith a closed GitHub issue publishes nothing and makes noghcalls. It fails on its own assertion without the guard (the PR is drafted) and passes with it.pnpm typecheck,pnpm check,pnpm knipandpnpm test(1086 passed) all pass locally.🤖 Generated with Claude Code
Assisted by Nebula.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.