ci: fix commentstart, conditions, defaultorrequired, optionalorrequired and defaults findings in api types - #1314
Open
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Conversation
Mesut Oezdil (mesutoezdil)
force-pushed
the
feat/kube-api-linter-fix-doc-findings
branch
from
August 29, 2026 09:13
04239f8 to
a339cf1
Compare
…ed and defaults findings in api types
Mesut Oezdil (mesutoezdil)
force-pushed
the
feat/kube-api-linter-fix-doc-findings
branch
from
September 3, 2026 08:25
a339cf1 to
a63855d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the commentstart, defaultorrequired, and optionalorrequired findings on
CSIDriverConfig,SandboxConfig, andWorkerPool: field godocs now start with the serialized field name,SandboxConfigSpec.SandboxClasshad both a default and required marker and is now optional with omitempty, and the previously unmarkedmetadata/spec/statusfields got their+optional/+requiredmarkers. Also addsWorkerPoolSpec.TerminationGracePeriodSecondsso worker pods can get a longer SIGTERM-to-SIGKILL window than the pod default, wired intoworkerpool_apply.go. Generated CRDs and deepcopy regenerated to match. MarkingCSIDriverConfig.Specas+requiredsurfaced a new requiredfields finding on that field, excluded alongside the existing SandboxConfig.Spec one pending issue #207.