docs: remove stale references to ActorTemplate as a Kubernetes CRD - #1404
Open
Youssuf Elshall (yelshall) wants to merge 1 commit into
Open
docs: remove stale references to ActorTemplate as a Kubernetes CRD#1404Youssuf Elshall (yelshall) wants to merge 1 commit into
Youssuf Elshall (yelshall) wants to merge 1 commit into
Conversation
Youssuf Elshall (yelshall)
force-pushed
the
docs/actortemplate-post-crd-cleanup
branch
from
September 2, 2026 18:17
b1018ef to
2d166d5
Compare
The ActorTemplate CRD was deleted when its resources moved to the
substrate gRPC API and the control-plane store (created and managed
with kubectl-ate, persisted in PostgreSQL). Several documents still
described ActorTemplate as a Kubernetes CRD, or described
namespace/RBAC relationships that no longer exist:
- architecture.md: the resource-model section, the persona
description, the governance rationale, and the UML class diagram
all placed ActorTemplate in kube-apiserver as a CRD. The diagram
also showed a "workerPoolRef" relation that does not exist; pool
selection is a label-based workerSelector match, and an Actor
references its template with the actor_template ref.
- glossary.md: ActorTemplate was listed under "Resources (declarative,
Kubernetes CRDs)", and the Atespace entry contrasted atespaces with
"the namespace an ActorTemplate lives in" (templates now live in
atespaces; WorkerPools live in namespaces).
- api-guide.md: the Best Practices section required ActorTemplate and
WorkerPool to share a namespace or RBAC; placement is actually by
sandboxClass and workerSelector labels. The ActorTemplate section
also kept CRD-era spec.-prefixed field paths ("ActorTemplateSpec",
"spec.volumes", "spec.resources") even though the protojson
manifest has top-level fields, and typed workerSelector as
*LabelSelector where the proto type is Selector.
- csi-volumes.md: same stale spec.-prefixed field paths, which
contradicted the top-level fields shown in its own YAML examples.
- api-style-guide.md: cited actor_template_name as an immutable field
example; the field is actor_template, and it is mutable - the
actor's immutable example is source_snapshot_tag.
- code-layout.md: described cmd/atecontroller as the controller for
WorkerPool/ActorTemplate; it now reconciles WorkerPools and
network/egress resources only.
- code comments: template_reconciler.go's goldenSnapshotWarmupFor
said it "mirrors the CRD controller's function of the same name;
keep both in sync" - the CRD controller was deleted, so that
instruction referenced nonexistent code. The claude-code-multiplex
demo UI comment labeled ActorTemplates as k8s CRDs, and
benchmarking/workloads/deploy.sh used a spec.-prefixed field path
in a comment (the protojson manifest is top-level).
- README.md: demo blurbs referenced "CRD routing" and templates
"across three namespaces"; routing goes through the Substrate
router, and the multi-template demo places templates in different
atespaces.
Youssuf Elshall (yelshall)
force-pushed
the
docs/actortemplate-post-crd-cleanup
branch
from
September 2, 2026 18:21
2d166d5 to
1b34a49
Compare
Collaborator
|
I see this PR is still in draft state, is this ready for review? |
Contributor
Author
Yes, ready for review now |
Youssuf Elshall (yelshall)
marked this pull request as ready for review
September 3, 2026 10:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Now that the ActorTemplate CRD has been deleted and its resources moved to the substrate gRPC API and the control-plane store (created/managed with
kubectl-ate, persisted in PostgreSQL), several documents still describe ActorTemplate as a Kubernetes CRD, or describe namespace/RBAC relationships that no longer exist. This sweeps the docs for those stale references.Fixes #368 (docs side).