Skip to content

ateapi: regenerate validation code with the current generator - #1516

Merged
Max Smythe (maxsmythe) merged 1 commit into
agent-substrate:mainfrom
dberkov:fix-codegen-ate-deepequal
Sep 5, 2026
Merged

ateapi: regenerate validation code with the current generator#1516
Max Smythe (maxsmythe) merged 1 commit into
agent-substrate:mainfrom
dberkov:fix-codegen-ate-deepequal

Conversation

@dberkov

Copy link
Copy Markdown
Collaborator

main is red since #1480 merged: its regenerated cmd/ateapi/internal/controlapi/zz_generated.validation.go was produced by a stale generator build and references deepEqualImpl_, which doesn't exist — cmd/ateapi (and everything importing controlapi) fails to compile, and every open PR inherits the failure through CI's merge-with-main (see #1512's run-tests for an example, and main's own post-merge pr-workflow runs for #1480/#1499).

Fix is a pure regeneration: hack/update/codegen.sh on current main changes exactly one line, deepEqualImpl_ateDeepEqual (the helper the current generator actually emits). After it, go build ./cmd/ateapi/... succeeds and go test ./cmd/ateapi/internal/controlapi/ passes.

No hand-written changes — the diff is generator output only.

🤖 Generated with Claude Code

The last regeneration of zz_generated.validation.go was produced by a
stale code-generator build: it references a deepEqualImpl_ helper that
no longer exists, so cmd/ateapi and everything importing controlapi
fail to compile, and every PR inherits the failure through CI's
merge-with-main. Rerunning hack/update/codegen.sh emits the current
helper name, ateDeepEqual.

@maxsmythe Max Smythe (maxsmythe) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe
Max Smythe (maxsmythe) merged commit 7a9abab into agent-substrate:main Sep 5, 2026
9 of 11 checks passed
@dberkov
Dmitry Berkovich (dberkov) deleted the fix-codegen-ate-deepequal branch September 5, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants