Fix plain text response logs - #1729
Open
TriTechAI wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1708.
monologue_endfallback extension that creates atype=responselog entry when the final AI response was saved to history but no live response log was produced.log_item_responsealready exists.Context
Some models return final answers as plain text instead of the expected
{"tool_name":"response","tool_args":{"text":"..."}}response-tool JSON. In that path, the answer is saved to history, but the WebUI never receives atype=responselog entry, so users can be left seeing only the last “Calling LLM...” entry.This change keeps the streaming parser path unchanged and adds a narrow fallback after streaming has ended, using the latest AI history message as the source of truth.
Testing
python3 -m py_compile extensions/python/monologue_end/_85_ensure_response_log.py tests/test_response_log_fallback.pyBlocked locally:
python3 -m pytest tests/test_response_log_fallback.pypytestinstalled (No module named pytest)