Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
The Nacos listener logged the full prompt template and its variable map at INFO on every successful update. Keep the template name for correlation and report the outcome of each individual update without logging its contents.
Does this pull request fix one issue?
Fixes #40
Describe how you did it
Log
result:appliedafter replacing a template. If its builder or customizer throws, log the template name, failure result and exception type. Propagate a sanitized failure without the original message or cause, which may contain configuration values. Processing still stops at the failed entry; earlier replacements remain applied.Describe how to verify it
Run
mvn -f prompt/argi-prompt-nacos/pom.xml testwith Java 21. The regression test captured both the prompt and the variable marker on the original implementation. It checks safe log messages and arguments on a partially applied batch, verifies the exception does not carry the original cause, and checks the following entry is not applied. The module passed all 20 tests locally, with no skips. No live Nacos server was used.Special notes for reviews
The auto-configuration README describes the new log fields and the per-template meaning of each result. The Logback dependency is test-scoped.