Skip to content

[AAASM-6358] ⬆️ (deps): Raise proxy-addr, source-map-js and MCP SDK floors to clear the audit - #524

Merged
Chisanan232 merged 1 commit into
mainfrom
v0.0.1/AAASM-6358/fix/audit_advisories
Oct 16, 2026
Merged

Chisanan232 merged 1 commit into
mainfrom
v0.0.1/AAASM-6358/fix/audit_advisories

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

Jira Ticket

https://lightning-dust-mite.atlassian.net/browse/AAASM-6358

Summary

dependency-audit (pnpm audit --audit-level=high) fails on every node-sdk PR (it only runs on pull_request, so main never shows it), failing the aggregate CI Success. Three advisories, all transitive via @openai/agents-core > @modelcontextprotocol/sdk > express:

Floors are added to pnpm-workspace.yaml overrides, per the file's existing convention (pnpm 11 ignores package.json overrides). No audit suppression.

Evidence

  • Reproduced on main before the change (3 vulnerabilities: 1 critical, 2 high).
  • After: pnpm audit --audit-level=high → "No known vulnerabilities found".
  • pnpm typecheck clean; pnpm test 748 passed, 2 skipped (74 files).
  • Lockfile diff: only proxy-addr 2.0.7→2.0.8, MCP SDK 1.29.0→1.32.1, source-map-js dedupe.

Unblocks PR #522 (AAASM-6352).

🤖 Generated with Claude Code

https://claude.ai/code/session_01M2jR4NNxxSWJokWJqTu4nd

…r the audit

proxy-addr >=2.0.8 (GHSA-jqcg-44mw-7w3h, critical), source-map-js >=1.2.2
(GHSA-68fv-2mgg-jv7q) and @modelcontextprotocol/sdk >=1.31 (GHSA-6qxp-vccf-f47h)
were failing dependency-audit on every pull request. Floors live in
pnpm-workspace.yaml per the existing convention. pnpm audit --audit-level=high:
no known vulnerabilities; typecheck and 748 vitest tests pass.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M2jR4NNxxSWJokWJqTu4nd
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chisanan232

Copy link
Copy Markdown
Contributor Author

LGTM / owner self-review record (head 4816185*, full SHA verified at merge).

Reviewed the full diff: pnpm-workspace.yaml overrides add floors proxy-addr ^2.0.8, source-map-js ^1.2.2, @modelcontextprotocol/sdk ^1.31.0 (GHSA-jqcg-44mw-7w3h critical, GHSA-68fv-2mgg-jv7q, GHSA-6qxp-vccf-f47h); pnpm-lock.yaml changes are limited to proxy-addr 2.0.7→2.0.8, MCP SDK 1.29.0→1.32.1 and a source-map-js dedupe. No audit suppression. Reproduced the failing pnpm audit --audit-level=high on main, then "No known vulnerabilities found" after the change; pnpm typecheck clean and pnpm test 748 passed locally. All checks green on this exact head incl. dependency-audit; mergeable; no unresolved finding.

Merging under the owner-only admin-merge exception (AAASM-5858) and the founder owner-admin-merge policy: verified identity Chisanan232 (org role admin); the only blocker is same-identity REVIEW_REQUIRED. Merge commit.

🤖 Generated with Claude Code

@Chisanan232
Chisanan232 merged commit d415849 into main Oct 16, 2026
31 checks passed
@Chisanan232
Chisanan232 deleted the v0.0.1/AAASM-6358/fix/audit_advisories branch October 16, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant