Repository navigation
[Q1] Reject unsupported matching priors consistently (#515) - #577
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #515
Matching priors above 0.5 previously reached Rust's graph builder as negative-weight edges even though Sparse Blossom cannot handle them and the CUDA-Q adapter rejected them. Probability 1 and non-finite mechanisms could also disappear silently.
All matching constructors now reject non-finite priors and values outside [0, 0.5] with
InvalidMatchingPrior { column, prob }. Validation precedes edge dropping and merging, so an invalid source prior cannot hide in an empty column or a parallel-edge combination. Native Python and CUDA-Q share the Rust range validation; inputs are never clamped. Zero and 0.5 remain supported; DEM construction and BP-family priors retain [0, 1]. Split constructors report split-model column indices.Boundary tests also exposed an infinite log-odds weight for the smallest positive f64. A log-difference fallback handles overflowing ratios while preserving the original expression and tested bit-identical weights for ordinary priors. Decoder algorithms, quantization and tie-breaking are unchanged.
Validation:
Policy, reproduction commands and recorded evidence. Genuine MWPM retrace ties and infeasible syndromes remain outside this change.