Skip to content

feat(review): show PR review status across views - #3

Closed
pmusaraj wants to merge 2 commits into
alysnnix:mainfrom
pmusaraj:feat/pr-review-status
Closed

pmusaraj wants to merge 2 commits into
alysnnix:mainfrom
pmusaraj:feat/pr-review-status

Conversation

@pmusaraj

@pmusaraj pmusaraj commented Sep 16, 2026

Copy link
Copy Markdown

feat(review): show PR review status

Pull request lists now show review status through the leading PR icon: green for approval, orange for requested changes, red for closed, and purple for merged. The main board and Projects share the same state precedence and accessible labels. Detail metadata lists “Approved by USERNAME” for each current approving reviewer.

GitHub's aggregate review decision takes precedence, with current opinionated reviews as a fallback when a repository has no required reviews. Closed, merged, and draft states override earlier review opinions. Detail queries paginate approving reviewers; dismissed and superseded approvals are excluded. Versioned cache namespaces prevent stale cached rows from hiding the new fields.

Validation:

  • Review branch: 65 tests passed; typecheck and lint passed.
  • Combined branch: 85 tests passed; typecheck and lint passed. Two existing lint complexity warnings remain in scripts/lib/scan.mjs.
  • Browser harness: main board, saved views, and Projects in light/dark themes at 390px and 1200px; PR glyphs, colors, and approver metadata verified using fixtures.
  • Local plugin reloaded successfully; live GitHub approved, changes-requested, closed, and merged PR responses verified.
  • Native mobile UI was not exercised.

- Color list icons for approval, changes requested, closed and merged states
- Attribute current approvals in detail metadata
- Keep the PR glyph for approval and requested changes.

- Fetch and render review status in Projects using the shared status rules.
@pmusaraj
pmusaraj marked this pull request as ready for review September 16, 2026 20:48
@pmusaraj pmusaraj closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant