Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43.
The standalone behavioral command prints each case's error before writing its report. On a strict cp1252 output stream, U+FFFD raises
UnicodeEncodeErrorthere. The final Markdown report contains the same error text, so its console write needs the same handling.Use the existing console fallback for the progress lines and the report. The JSON artifact and Markdown summary keep the original text. This covers the Python CLI entry point. #30 handles the separate Actions launcher.
I ran the CLI handler with two fixture cases and a setup error containing U+FFFD, with stdout backed by a strict cp1252 stream. Before the change it raised on the first result line. Afterward both result lines printed, the command returned the expected failure status for the two failed cases, and both report files preserved U+FFFD. All 619 tests passed on Python 3.12. This exercised the codec locally without a Windows runner or a live model.