Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #107, which contains the same commit and changes under the replacement branch.
The fractional-lag fix was already implemented, but the recovery tests compared the same sweep index from separate campaigns and therefore reused receiver-noise streams. A temperature/strain pair could pass without demonstrating recovery from independently noisy acquisitions.
This change completes the remaining validation for #105:
Validation on Windows / Python 3.12.10 (NumPy 2.5.4, SciPy 1.18.1): full suite 726 passed, 4 existing time-warp warnings; targeted tests 28 passed.
git diff --checkpassed. Across the 16 new pipeline cases, maximum absolute relative median bias was 0.601%, window RMSE 2.781%, and absolute receiver-noise correlation 0.00386. Maximum noiseless circular lag error was 1.04e-8 bins. Negative controls showed correlation 1.0 when reusing a sweep, and the old parabolic estimator recovered 6.733 K from a +5 K input and failed the new recovery criteria.Production code and estimator behavior are unchanged. These cases validate the stated simulated receiver-noise regime, not experimental accuracy or robustness to arbitrary noise/decorrelation.
Related: #105.