feat(action-sheet): add initialVisible prop for immediate rendering#506
Open
deyvid-bardarov wants to merge 1 commit into
Open
feat(action-sheet): add initialVisible prop for immediate rendering#506deyvid-bardarov wants to merge 1 commit into
deyvid-bardarov wants to merge 1 commit into
Conversation
|
@deyvid-bardarov is attempting to deploy a commit to the Ammar Ahmed's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
initialVisibleprop for immediate renderingSummary
initialVisibleprop toActionSheetPropsthat allows the sheet to be visible immediately on initial render, without the opening animation.initialVisibleistrue, the sheet sets its opacity and position directly to their open-state values instead of running the spring animation, avoiding any flicker or delay.initialVisiblethrough touseSheetManagerso the internalvisiblestate is initialized totrue.This eliminates the need for workarounds like calling
ref.show()inside asetTimeoutafter mount.Closes #404
Test plan
initialVisiblerenders fully open on mount with no animation flickerinitialVisiblestill animates open as before (no regression)