Repository navigation
feat(amp-semantic): scaffold semantic capture package - #2113
Merged
Merged
Conversation
size-limit report 📦
|
Session Replay Browser E2E ResultsDetails
|
jxiwang
marked this pull request as ready for review
November 3, 2026 18:01
daniel-graham-amplitude
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Establish the
@amplitude/amp-semanticworkspace package before adding event capture. This PR contains package metadata, clean CommonJS/ESM builds and declarations, lint/test setup, shared version/identity/envelope contracts, and public-contract tests. Package ownership is assigned to@amplitude/session-replay-sdkin.github/CODEOWNERS.There are no event families, recorders, capture runtime, browser listeners, storage access, or Session Replay changes in this PR. No existing SDK depends on the package yet.
Merge sequence
The complete implementation remains preserved in #2082. The context/visibility implementation is preserved in #2120 (
codex/semantic-context-visibility-events).Validation
pnpm test --concurrency=2: all 32 projects passed, including the scaffold's public-contract test with 100% coverage.pnpm test:examplescannot start becausejest.setup.examples.jsis absent from main.Checklist
Note
Low Risk
Greenfield scaffold with types and tests only; no changes to existing SDKs or capture behavior.
Overview
Introduces
@amplitude/amp-semanticas a new workspace package—the first increment toward semantic event capture, with no runtime capture or Session Replay wiring yet.The package adds standard monorepo tooling (CJS/ESM builds with a clean
libstep, typecheck, Jest, ESLint) and documents a planned multi-PR rollout. Public API is limited toSEMANTIC_VERSION,SemanticIdentity(tab_id,document_id), and the genericSemanticEventEnvelopetype that merges caller payload with version and identity. Tests exercise JSON shape and compile-time constraints on event names and required metadata.CODEOWNERS assigns
/packages/amp-semantic/to@amplitude/session-replay-sdkalongside other Session Replay packages.pnpm-lock.yamlregisters the new package’stslibandrimrafentries.Reviewed by Cursor Bugbot for commit 82928e0. Bugbot is set up for automated code reviews on this repo. Configure here.