Skip to content

feat(amp-semantic): capture navigation keys and shortcuts - #2154

Draft
jxiwang wants to merge 4 commits into
codex/semantic-interaction-eventsfrom
codex/semantic-keys
Draft

jxiwang wants to merge 4 commits into
codex/semantic-interaction-eventsfrom
codex/semantic-keys

Conversation

@jxiwang

@jxiwang jxiwang commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add amp-semantic/keys for navigation keys and Ctrl/Meta K, P, and F shortcuts only.
  • Describe the rrweb target with its role, accessible name, and states, while excluding typed characters, composition, repeats, and editable contents.
  • Add schema, docs, local inspector description, unit tests, and a browser replay test. Supersedes the keys portion of the older draft feat(session-replay): integrate semantic lifecycle capture #2080.

Stack

Base: #2153. Merge after #2128 and #2150–#2153.

Validation

  • pnpm --filter @amplitude/amp-semantic... build
  • pnpm --filter @amplitude/session-replay-browser... build
  • pnpm --filter @amplitude/amp-semantic test: 140 passed, 100% coverage
  • pnpm --filter @amplitude/session-replay-browser test: 1,183 passed, 100% coverage
  • pnpm --filter @amplitude/amp-semantic test:playwright: 12 passed
  • pnpm lint, pnpm lint:deps, pnpm test:examples

The full workspace build stalls in the unchanged Segment Session Replay Rollup step, and the full workspace test run has two existing analytics-react-native failures, as documented in earlier stack drafts.

Linear: SRAI-81.

@github-actions

Copy link
Copy Markdown

size-limit report 📦

Path Size
packages/analytics-browser/lib/scripts/amplitude-min.js.gz 68.41 KB (0%)
packages/session-replay-browser/lib/scripts/session-replay-browser-min.js.gz 141.27 KB (0%)
packages/unified/lib/scripts/amplitude-min.umd.js.gz 227.79 KB (0%)
@amplitude/element-selector (gzipped esm) 3.48 KB (0%)
@amplitude/analytics-browser/lite (gzipped CDN bundle) 21.34 KB (0%)

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Session Replay Browser E2E Results

passed  158 passed
flaky  1 flaky

Details

stats  159 tests across 18 suites
duration  4 minutes, 29 seconds
commit  ac57497

Flaky tests

chromium › e2e/shadow-dom.spec.ts › captureAdoptedStyleSheets option › SDK initializes without error and captures shadow host with captureAdoptedStyleSheets=false

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant