Skip to content

feat(amp-semantic): capture replay-driven notices and dialogs - #2156

Draft
jxiwang wants to merge 4 commits into
codex/semantic-resource-errorsfrom
codex/semantic-feedback-events
Draft

jxiwang wants to merge 4 commits into
codex/semantic-resource-errorsfrom
codex/semantic-feedback-events

Conversation

@jxiwang

@jxiwang jxiwang commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add amp-semantic/notice and amp-semantic/dialog from accepted rrweb snapshots and mutations, including privacy-aware text/name, open/close state, visibility, and recent click correlation.
  • Resolve relevant rrweb node IDs through the recorder mirror. The feedback recorder does bounded work per animation frame and adds no MutationObserver or full-page DOM scan.
  • Extend schema, local inspector, browser replay test, and unit/pressure tests. Supersedes the notice/dialog portion of older draft feat(amp-semantic): capture page state and UI feedback #2081.

Stack

Base: #2155. Merge after #2128 and #2150–#2155.

Validation

  • pnpm --filter @amplitude/session-replay-browser... build
  • pnpm --filter @amplitude/amp-semantic test: 182 passed, 100% coverage
  • pnpm --filter @amplitude/session-replay-browser test: 1,185 passed, 100% coverage
  • pnpm --filter @amplitude/amp-semantic test:playwright: 14 passed
  • pnpm lint, pnpm lint:deps, pnpm test:examples

The full workspace build stalls in the unchanged Segment Session Replay Rollup step, and the full workspace test run has two existing analytics-react-native failures, as documented in earlier stack drafts.

Linear: SRAI-61, SRAI-62.

@github-actions

Copy link
Copy Markdown

size-limit report 📦

Path Size
packages/analytics-browser/lib/scripts/amplitude-min.js.gz 68.41 KB (0%)
packages/session-replay-browser/lib/scripts/session-replay-browser-min.js.gz 141.44 KB (+0.12% 🔺)
packages/unified/lib/scripts/amplitude-min.umd.js.gz 227.95 KB (+0.08% 🔺)
@amplitude/element-selector (gzipped esm) 3.48 KB (0%)
@amplitude/analytics-browser/lite (gzipped CDN bundle) 21.34 KB (0%)

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Session Replay Browser E2E Results

passed  158 passed
flaky  1 flaky

Details

stats  159 tests across 18 suites
duration  4 minutes, 24 seconds
commit  e1f30ca

Flaky tests

chromium › e2e/shadow-dom.spec.ts › captureAdoptedStyleSheets option › SDK initializes without error and captures shadow host with default (true)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant