Fix two stale/missing .gitignore rules, found comparing against EC - #30
Merged
Merged
Conversation
- The publish-profile un-ignore rules still pointed at the pre-reorg root-level path (!Properties/PublishProfiles/...). LEN's sources/ reorg moved these files to sources/LineEndingNormalizer/Properties/ PublishProfiles/, so the rule matched nothing (confirmed via git check-ignore). Not currently breaking anything since both files are already tracked, but either would be silently re-caught by *.pubxml if ever deleted and re-added. Fixed to match EC's own already-correct sources/EncodingChecker/ prefix. - Added **/.claude/settings.local.json, present in EC but missing here. Nothing currently stopped this machine-specific file from being swept up by a broad git add. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!Properties/PublishProfiles/...). LEN'ssources/reorg moved these files tosources/LineEndingNormalizer/Properties/PublishProfiles/, so the rule matched nothing (confirmed viagit check-ignore). Not currently breaking anything since both files are already tracked, but either would be silently re-caught by*.pubxmlif ever deleted and re-added. Fixed to match EC's own already-correctsources/EncodingChecker/prefix.**/.claude/settings.local.json, present in EC but missing here. Nothing currently stopped this machine-specific file from being swept up by a broadgit add.Test plan
git check-ignoreconfirms.claude/settings.local.jsonis now ignoredgit check-ignoreconfirms the two.pubxmlfiles are correctly un-ignored at their real pathgit statusclean, no unintended changes🤖 Generated with Claude Code