Skip to content

Add issue in Demo application #14

Description

@Scantheus

I tested the ability to add to a collection by enabling the Dbg button and adding code to perform an add to DbgButton_Click (Commenting out the break). It adds an item to _items and then does an add to the collection (MyDataVirtualizedAsyncFilterSortObservableCollection.Add(newItem).

However, it caused a not implemented exception in GetItemsAt in RemoveOrDbDataSourceAsyncProxy.cs.

Steppoing through the code I found that FillPageFromAsyncProvider in PaginationManager.cs was calling GetItemsAt which, according to comments, is for sync only. If it is async, I believe it should call GetItemsAtAsync.

I commented out the GetItemsAt and added GetItemsAtAsync and the add now works.

// var data = this.ProviderAsync.GetItemsAt(pageOffset, newPage.ItemsPerPage, false);
var data = this.ProviderAsync.GetItemsAtAsync(pageOffset, newPage.ItemsPerPage, false).Result;

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions