[companion] test: isolate systemd install from host OMP_WEB_OMP_BIN

[andrebrait]

Review-only companion for kahme247#108 — do not merge.

Same head (fix/upstream-tests @ 243a70c) and base pinned to upstream/main (companion/upstream-main @ b4c29e2) so the diff is identical.

Summary

Delete OMP_WEB_OMP_BIN from the systemd LAN-settings install test child env, matching the existing PI_CODING_AGENT_DIR isolation.

Summary by CodeRabbit

• Tests
  • Updated installation testing to ensure the runtime binary path is not unintentionally passed to the installer process.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ec5ad085-516a-41d9-9a1b-90e0ab85fbc0

📥 Commits

Reviewing files that changed from the base of the PR and between b4c29e2 and 243a70c.

📒 Files selected for processing (1)

• bin/omp-web-systemd.test.mjs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The install test now removes OMP_WEB_OMP_BIN from the child environment before spawning the installer. This prevents the parent process value from reaching the installer.

Changes

Installer environment isolation

Layer / File(s)	Summary
Install test environment setup bin/omp-web-systemd.test.mjs	The test deletes OMP_WEB_OMP_BIN from the child environment before starting the installer.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: kahme247

Merge Risk: ⚪ Minimal · up to 243a7

The test now isolates the installer from the host runtime binary setting, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the systemd install test and the isolation of the host OMP_WEB_OMP_BIN value. It accurately summarizes the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/upstream-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[andrebrait]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.