[companion] feat(settings): show attention indicator on tabs and update cards by andrebrait · Pull Request #32 · andrebrait/ompweb

andrebrait · 2026-09-19T08:06:47Z

Companion PR for kahme247#115 to run bot reviews (Copilot, CodeRabbit).

Upstream PR: kahme247#115

Summary by CodeRabbit

New Features
- Settings now highlight available app and OMP updates with accent styling and status indicators.
- The System tab displays an attention badge when updates require review.
- Added accessible update labels and visual indicators across vertical and horizontal settings layouts.
- Added English, Japanese, and Simplified Chinese translations for update notifications.
Tests
- Added coverage for settings tab attention indicators and accessible labels.

…gthen tests

coderabbitai · 2026-09-19T08:06:53Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c3ef93ef-9c24-4ab3-98ec-387bb426090f

📥 Commits

Reviewing files that changed from the base of the PR and between 330db7d and f902c7c.

📒 Files selected for processing (7)

components/AppShell.tsx
components/SettingsConfig.tsx
components/SettingsTabs.test.mjs
components/SettingsTabs.tsx
lib/i18n/locales/en.json
lib/i18n/locales/ja.json
lib/i18n/locales/zh-CN.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

AppShell passes OMP update state to SettingsConfig. Settings derives update indicators for the system tab and update cards. SettingsTabs renders attention indicators, accessible labels, and localized messages in both layouts.

Changes

Settings update attention

Layer / File(s)	Summary
Update state and card indicators `components/AppShell.tsx`, `components/SettingsConfig.tsx`	`SettingsConfig` receives OMP update availability, derives update flags, marks the System tab, and highlights app and OMP update cards.
Settings tab attention rendering `components/SettingsTabs.tsx`, `components/SettingsTabs.test.mjs`, `lib/i18n/locales/*.json`	Settings tabs show attention dots and accessible update text in vertical and horizontal layouts. English, Japanese, and Chinese labels are included, with tests for the rendered labels.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant AppShell
  participant SettingsConfig
  participant SettingsTabs
  AppShell->>SettingsConfig: pass ompUpdateAvailable
  SettingsConfig->>SettingsConfig: derive update flags
  SettingsConfig->>SettingsTabs: pass attentionTabs
  SettingsTabs->>SettingsTabs: render indicator and accessible label

Suggested reviewers: kahme247

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (3 skipped: 3 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main changes: attention indicators on settings tabs and update cards.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (3 skipped: 3 unsupported.)

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

andrebrait · 2026-09-19T08:06:57Z

@coderabbitai review

coderabbitai · 2026-09-19T08:07:02Z

⚠️ Action not completed

Pull request base or head changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot

Copilot review overview

🟡 Changes recommended

Runtime attention state can become stale, failed checks can show an indefinite loading message, and vertical tab indicators are not reliably accessible.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 3

Open (3)

AppShell update status becomes stale after local result · New
Failed update checks remain stuck in loading state · New
Update indication is inaccessible within the tab · New

What changed in this PR

Adds update-attention indicators to Settings tabs and update cards, with localized labels and rendering tests.

Changes:

Added localized attention strings.
Propagated runtime update state into settings and highlighted update cards.
Added vertical/horizontal tab indicator tests.

File	Description
`components/AppShell.tsx`	Passes runtime update availability to settings.
`components/SettingsConfig.tsx`	Displays attention indicators and highlighted update cards.
`components/SettingsTabs.tsx`	Renders attention indicators for settings tabs.
`components/SettingsTabs.test.mjs`	Tests attention indicators in both layouts.
`lib/i18n/locales/en.json`	Adds English attention labels.
`lib/i18n/locales/ja.json`	Adds Japanese attention labels.
`lib/i18n/locales/zh-CN.json`	Adds Chinese attention labels.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…tates, and tab accessible names

Copilot

Copilot review overview

🟡 Changes recommended

OMP update styling can become inconsistent because the new status color uses nullish coalescing instead of combining both availability sources.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Use OR to keep update status text consistent with indicator · New

Resolved since last review (3)

Update indication is inaccessible within the tab
Failed update checks remain stuck in loading state
AppShell update status becomes stale after local result

andrebrait · 2026-09-19T08:19:20Z

@coderabbitai review

coderabbitai · 2026-09-19T08:19:25Z

⚠️ Action not completed

Head commit changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

andrebrait · 2026-09-19T08:20:41Z

@coderabbitai full review

coderabbitai · 2026-09-19T08:20:47Z

✅ Action performed

Full review finished.

Copilot

Copilot review overview

🟢 Approval recommended

The changes are localized, tested across both layouts, and introduce no unresolved correctness issues.

Review effort: Lite
Findings: None

Resolved since last review (1)

Use OR to keep update status text consistent with indicator

andrebrait added 2 commits September 18, 2026 22:23

feat(settings): show attention indicator on tabs and update cards

906ae79

fix(settings): gate OMP version text on loaded update state and stren…

80a3a1b

…gthen tests

andrebrait requested a lite review from Copilot September 19, 2026 08:06

Copilot started reviewing on behalf of andrebrait September 19, 2026 08:07 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

Comment thread components/SettingsConfig.tsx Outdated

Comment thread components/SettingsConfig.tsx Outdated

Comment thread components/SettingsTabs.tsx Outdated

fix(settings): address Copilot review feedback on reactivity, error s…

9a245e3

…tates, and tab accessible names

andrebrait requested a lite review from Copilot September 19, 2026 08:13

Copilot started reviewing on behalf of andrebrait September 19, 2026 08:13 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

Comment thread components/SettingsConfig.tsx Outdated

fix(settings): use ompUpdateIsAvailable consistently for status color

f902c7c

andrebrait requested a lite review from Copilot September 19, 2026 08:20

Copilot started reviewing on behalf of andrebrait September 19, 2026 08:20 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

Conversation

andrebrait commented Sep 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

andrebrait commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

andrebrait commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrebrait commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andrebrait commented Sep 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading