Repository navigation
Always sync AgentTypeIndexCostOverrides to the landmass agent. - #197
Closed
goulvenclech wants to merge 1 commit into
Closed
goulvenclech wants to merge 1 commit into
goulvenclech wants to merge 1 commit into
Conversation
Owner
|
I don't think I'll be accepting this PR, since it means that we're cloning the type_index_cost_overrides every single frame, which is not ideal. So I wrote my own fix at #198 (with the caveat that it is possible to break it if you add the AgentTypeIndexCostOverrides first, and then add the agent components). I did take your tests though, they were good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196.
Instead of only skipping the update when the component is unchanged, this syncs the overrides every time, like the agent's other inputs. The change check also missed the landmass agent being recreated (switching archipelagos, or the archipelago being added later or replaced), which silently dropped the overrides. Once in sync, it's a few map lookups per agent and allocates nothing.