CI: fix release asset upload token permission - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Release Docker Imageworkflow failed on v0.63 at the Upload OpenAPI spec to release step with:The image built and pushed fine; only the release-asset upload failed.
Root cause
The dedicated
MEMORYALPHA_RAG_API_MODIFY_RELEASE_TOKENwas passed tosoftprops/action-gh-release@v2as aGITHUB_TOKENenv var. But that action'stokeninput defaults togithub.token, and per its docs "A non-empty explicit token overrides GITHUB_TOKEN." So the default token won — and the workflow only granted itcontents: read, which can't modify releases.Fix
tokeninput underwith:(so it's actually used).permissionstocontents: writeas a fallback so the default token can also write releases.Unrelated to the earlier port fix (the OpenAPI-generate step passed). After merge, cut a new release to verify the asset uploads.