Skip to content

fix: CLS to reach 100% performance #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annacv merged 1 commit into from
Sep 16, 2026
Merged

fix: CLS to reach 100% performance #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
<head>
<meta charset="UTF-8">
<link rel="icon" href="/favicon.ico">
<link
rel="preload"
as="font"
type="font/woff2"
href="/src/assets/fonts/Inter/Inter-Variable.woff2"
crossorigin
>
<link rel="preload" as="image" href="/bg-galaxy.svg" fetchpriority="high">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>SWAPI Planets</title>
Expand Down
Binary file removed src/assets/fonts/Inter/Inter-Variable.ttf
View file
Open in desktop
Binary file not shown.
Binary file added src/assets/fonts/Inter/Inter-Variable.woff2
View file
Open in desktop
Binary file not shown.
5 changes: 4 additions & 1 deletion src/assets/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
font-style: normal;
font-display: swap;
font-weight: 100 900;
src: url('./fonts/Inter/Inter-Variable.ttf') format('truetype');
src: url('./fonts/Inter/Inter-Variable.woff2') format('woff2');
unicode-range:
U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329,
U+2000-206F, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}

@theme {
Expand Down
5 changes: 4 additions & 1 deletion src/views/PlanetsView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import PlanetMap from '@/components/PlanetMap.vue'
import PlanetsList from '@/components/PlanetsList.vue'
import StatusMessage from '@/components/StatusMessage.vue'
import Toolbar from '@/components/Toolbar.vue'
import { usePlanetsStore } from '@/stores/planets'
import { PAGE_SIZE, usePlanetsStore } from '@/stores/planets'
import { getListStatusMessage } from '@/utils/listStatusMessage'

const planetsStore = usePlanetsStore()
Expand Down Expand Up @@ -72,8 +72,11 @@ onMounted(() => {
/>
</section>

<!-- Reserve one page of list height during loading to cut Cumulative Layout Shift (CLS)
when rows mount. 2.25rem is the row height; 1rem is `gap-4` so the box is not short on mobile. -->
<section
class="flex flex-1 flex-col gap-6 px-6 pb-6 lg:col-start-2 lg:row-start-2 lg:px-10 lg:pr-16 xl:pr-32"
:style="{ minHeight: `calc(${PAGE_SIZE} * 2.25rem + ${PAGE_SIZE - 1} * 1rem)` }"
>
<p v-if="listLoading" class="mt-10 text-sm text-muted">Loading planets…</p>

Expand Down
Loading