Repository navigation
ci: key the windows target cache on the msvc toolset - #1863
Merged
Merged
Conversation
thdxr
force-pushed
the
ci-windows-cache-toolset
branch
from
November 15, 2026 17:53
350ac0a to
8dcc81f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-11-arm mixes image builds that install different msvc toolsets (14.51 and 14.52), and rust-cache caches
target/, transcribe-cpp's static C++ objects included. a cache saved on the newer image and restored on the older one links 14.52-builttranscribe.cpp.objagainst 14.51'slibcpmt.lib:LNK2019 unresolved external symbol __std_replace_2.env-varsvalues are hashed into the cache key and into the restore-key, so naming the image build keeps a restoredtarget/from crossing toolset changes.ImageVersionis the variable these images actually set, and it moves with the toolset.INCLUDE/LIBare listed too for runners that export them; windows-11-arm doesn't, so on their own they hash nothing (first run below shows that).evidence: runs 43737116521, 43738834115, 43657087210, 43639058668 all restore one entry onto image 20261101.203, whose outer link gets
...\VC\Tools\MSVC\14.52.37025\...LIBPATHs from the cached build whilelink.exeis 14.51.after, on image 20261112.217: restore key
v0-rust-arm64-Windows_NT-arm64-a3f94b7f(wasv0-rust-arm64-Windows_NT-arm64-f67a6798), cold build, 2091 tests pass (run 43743679915).— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊