Repository navigation
Drop Docker Hub image job; keep GHCR - #12
Merged
Merged
Conversation
The docker-image job failed every PR: DOCKERHUB_USERNAME/PASSWORD are unset. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly removes a consistently failing Docker Hub publish job without impacting the existing GHCR build/push path.
Pull request overview
This PR removes the Docker Hub image publishing job from the CI workflows to stop failures caused by missing Docker Hub credentials, while keeping the GHCR image publishing path used by downstream consumers.
Changes:
- Removed the
docker-imagejob fromtest.yml,build.yml, andrelease.yml. - Kept the existing
ghcr-imagejobs intact for PRs /main/ tagged releases.
File summaries
| File | Description |
|---|---|
| .github/workflows/test.yml | Removes Docker Hub publish job that was failing PR runs; GHCR publish remains for internal PRs. |
| .github/workflows/build.yml | Drops Docker Hub publish on main builds; preserves GHCR latest image push. |
| .github/workflows/release.yml | Removes Docker Hub publish on tag releases; preserves GHCR version + latest image push. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-imagejob from Test / Build / Release. It logged into Docker Hub with empty secrets and failed every Dependabot PR (Username and password required).Test plan
docker-imageghcr-imagestill runs on PRs and onmainMade with Cursor