Repository navigation
test(core): add isolated unit tests and CI gate - #168
Conversation
Add xUnit.net v3 tests for Core use cases and frame input handling, with locked test dependencies and contributor verification instructions. Co-authored-by: Codex <noreply@openai.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Describe compatibility in the unit-test guide and link to the SDK selection, package constraints, and lockfile instead of duplicating patch versions. Co-authored-by: Codex <noreply@openai.com>
|
Warning This comment was created with assistance from LLMs. @codex review Please review the latest documentation-only commit: keep compatibility identifiers in the unit-test guide and delegate exact SDK/package selection to the build configuration and lockfile. No dependency or runtime behavior was changed. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
State the .NET 10 prerequisites directly, put execution steps before scope and framework details, and reserve lockfile review for dependency updates. Align the README prerequisite with the supported SDK line. Co-authored-by: Codex <noreply@openai.com>
|
Warning This comment was created with assistance from LLMs. @codex review Please review the latest documentation commit for a self-contained test runbook: .NET 10 prerequisites are stated directly, execution steps precede scope details, and lockfile review is part of the intentional dependency-update procedure. Check the related README prerequisite for consistency. The change is limited to these two documents. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Warning
This pull request was created with assistance from LLMs.
Summary
net10.0xUnit.net v3 test project referencing the production assembly, with hand-written fakes and 44 tests for Core authorization, save/load outcomes, input suppression, magnet feedback, and result presentation.netstandard2.1and preserve its dependency graph.Related Issues
Notes for reviewers
Internal production types remain internal; only the test assembly receives friend access. Tests exercise Core through its ports and do not establish Unity, Harmony, or multiplayer runtime compatibility.
Attribution: the implemented issue author and PR creator are both @aoirint; no additional human co-author trailer is proposed for that same primary-author role. Material AI implementation is attributed with
Co-authored-by: Codex <noreply@openai.com>.AI disclosure
The user asked Codex to implement Issue #51, prepare a draft PR, and address automated review. Codex wrote the tests, CI integration, lockfile, and documentation, inspected the diff and dependencies, and ran the checks below. The maintainer confirmed the CLA in the PR checklist and authorized merging.
Testing
Automated checks
dotnet restore --locked-mode -m:1,dotnet build --no-restore -m:1, anddotnet test --no-restore --no-build -m:1(44 passed, 0 failed, 0 skipped).git diff --check.dotnet format --no-restore --verify-no-changesand parallel solution builds are blocked by IPC socket permission errors. Single-node build/test succeeds; the full formatter, standard build/test commands, and pin validation all passed in the latest-head Check run (44 tests passed).pinact run --check --min-age 7failed because GitHub's API returned HTTP 504 while checking the existing checkout pin. No external action pin was changed.AI-assisted inspections
Request: verify the current Core contracts and keep test dependencies outside the player package.
IPluginLoggerandIValidationLoggerports; packaging still copies only the production plugin DLL, and the production lockfile is unchanged.Request: obtain automated reviews for the published head.
Request: make the test runbook self-contained for human readers.
Checklist
As the pull request author, I have checked all required items:
CONTRIBUTING.mdand agree to the Contribution License Agreement.