Repository navigation
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This pull request was created with assistance from LLMs.
Summary
Select stable .NET SDK 11.0.100 through
global.json; existing CI reads that file.Set
minPublishAgeHours="168"on both existing NuGet sources and document automatic-selection behavior, NU1020, and restore limitations.Replace floating BepInEx.Analyzers and BepInEx.PluginInfoProps references with the already-resolved 1.0.8 and 2.1.0 versions. Their resolved versions remain unchanged.
Move the test/development harness to
net11.0and remove the .NET 10 SDK installation from CI and documentation.Related Issues
The maintainer completion criterion is merging the SDK migration with a seven-day source cooldown. This PR implements that scope. Restore-time age validation and explicit-version filtering remain upstream gaps and are outside its completion criteria. GitHub will close the issue only when this PR is merged into the default branch.
Notes for reviewers
The SDK upgrade enables NuGet 8's minimum package publish age. The official .NET 11 release metadata identifies 11.0.100 as the latest stable SDK on 2026-11-15, released 2026-11-10. This explicitly requested SDK migration uses an STS SDK for a concrete NuGet tooling capability. Its release is five days old at preparation; the normal seven-day external-tool waiting period reaches seven days on 2026-11-17. Review this timing before integration.
Both configured feeds expose registration publication metadata: nuget.org example and BepInEx example. Metadata availability for these samples does not guarantee every future version has a timestamp. Automatic version selection errors when required publication metadata is missing.
The game-loaded plugin target (
netstandard2.1), language versions, game/loader dependencies, and all retained package versions and content hashes are preserved. Only the test harness target changes to .NET 11. Source URLs, mappings, and exception policy are unchanged. Ordinary and locked restore do not validate dependency age; explicit version requests bypass the cooldown. No custom verifier is added. APM pins and generated Skills are unchanged. No merge, auto-merge, release, or issue mutation is performed by this PR preparation.Regenerated the test lockfile with SDK 11.0.100 using
dotnet restore --force-evaluate --use-lock-file, then verifieddotnet restore --locked-mode. SDK package pruning removes the redundantSystem.Reflection.TypeExtensions4.7.0 transitive entry from the net11.0 test graph; no package versions are upgraded.AI disclosure
Codex inspected repository guidance, edited SDK/NuGet configuration and maintenance documentation, and ran the checks below. Game runtime behavior remains unverified.
Testing
Automated checks
dotnet --versionselected 11.0.100 in this worktree.dotnet restore --locked-mode: passed.dotnet format --no-restore --verify-no-changes: passed.dotnet test --no-restore --no-build -c Release: all 44 xUnit tests passed targeting and running on .NET 11.actionlint -pyflakes=andpinact run --check --min-age 7: passed.apm audit --ciusing the existing local APM 0.34.0: all ten deployment checks passed; organization policy retrieval was unavailable, so organization policy enforcement is unverified. CI retains pinned APM 0.35.0. No lock operation was performed.git diff --check: passed. No standalone shell scripts changed.AI-assisted inspections
global.json; product runtime/package identities and retained package versions remain intact. NuGet limitations are documented, and no upstream feature is implemented locally.Manual checks
In-game validation was not performed. No live audio or gameplay compatibility claim is made.
Checklist
CONTRIBUTING.mdand agree to the Contribution License Agreement.The submitter must confirm the contributor agreement before this draft is merged.