Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .agents/skills/apm-workflow/references/apm-bootstrap.json
Original file line number Diff line number Diff line change
@@ -1,40 +1,40 @@
{
"version": "v0.34.0",
"published_at": "2026-10-19T12:00:55Z",
"version": "v0.35.0",
"published_at": "2026-10-22T22:51:41Z",
"cooldown_days": 7,
"eligible_on": "2026-10-26T12:00:55Z",
"release_url": "https://github.com/microsoft/apm/releases/tag/v0.34.0",
"eligible_on": "2026-10-29T22:51:41Z",
"release_url": "https://github.com/microsoft/apm/releases/tag/v0.35.0",
"download_url_template": "https://github.com/microsoft/apm/releases/download/{version}/{asset}",
"assets": [
{
"platform": "macos-arm64",
"archive": "apm-darwin-arm64.tar.gz",
"extracted_directory": "apm-darwin-arm64",
"sha256": "030b381825799333ac60a369aaf021ffc9f9e92558b375feec656c42e50e8e5a"
"sha256": "cb2c54152e3bd39acfe2fbda4a2aa91d2af914e24859d3623423efd7b27e3dd0"
},
{
"platform": "macos-x86_64",
"archive": "apm-darwin-x86_64.tar.gz",
"extracted_directory": "apm-darwin-x86_64",
"sha256": "55b4ab44eaca6f3a56f59a8e9ca84082c9ed3333a76fe255d6bc62c2a14678a9"
"sha256": "ee17daf433c49ed481d9f2ddee31825cbced9390637cab9a5138815bbace327c"
},
{
"platform": "linux-arm64",
"archive": "apm-linux-arm64.tar.gz",
"extracted_directory": "apm-linux-arm64",
"sha256": "bf355449cbb74b960e3a6ebe851a35ec2c1df6f5178fbb36b90c5a3a015d2c2a"
"sha256": "ada8901ce1b29e5d188629eeed64e8499853a8cb5f047630ebedbde24008508e"
},
{
"platform": "linux-x86_64",
"archive": "apm-linux-x86_64.tar.gz",
"extracted_directory": "apm-linux-x86_64",
"sha256": "4487af55604b4fa6f4587f3ee6e833b44ce99c491f11069790e4e13e297cde8c"
"sha256": "5aa23ce61eebae9411668f507772cdb5d87252c760078dc59b5acdc5188d785b"
},
{
"platform": "windows-x86_64",
"archive": "apm-windows-x86_64.zip",
"extracted_directory": "apm-windows-x86_64",
"sha256": "e9b3dd16b8533af681ea70128ceb8baed983c47cd73d0488ff28dbd5df85def0"
"sha256": "9a0a912b3ba68ac154b940e1931425c85f03edcfcc2339661d3aa32d8fa17c2f"
}
]
}
3 changes: 2 additions & 1 deletion .agents/skills/code-quality-check/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

## Overview

Review implementation changes for readability, maintainability, and verification.
Review implementation changes for readability, maintainability, verification,
and evidence-backed migration or compatibility needs.

## Install

Expand Down
7 changes: 4 additions & 3 deletions .agents/skills/code-quality-check/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ description: >-
1. Read the changed files and nearby call sites, not just the patch.
2. Identify code that is hard to scan, overly nested, duplicated, misleadingly named, or coupled to
hidden assumptions.
3. When a change adds future-facing structure, abstraction, validation, dependencies, tests, or
defensive behavior, use [avoiding overengineering](references/avoiding-overengineering.md) to
check that each addition has a current consumer, contract, failure mode, or evidenced risk.
3. When a change adds future-facing structure, abstraction, validation, dependencies, tests,
compatibility layers, migration paths, or defensive behavior, use
[avoiding overengineering](references/avoiding-overengineering.md) to check that each addition has
a current consumer, contract, failure mode, or evidenced risk.
4. Make safe local readability refactors where practical.
5. Add or update comments only when the design intent is not obvious from the code and cannot be
made obvious with a small refactor.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Avoiding overengineering

## Contents

- [Purpose](#purpose)
- [Decision rule](#decision-rule)
- [Migration and backward compatibility](#migration-and-backward-compatibility)
- [Common review examples](#common-review-examples)
- [Boundaries that justify structure](#boundaries-that-justify-structure)
- [Review outcome](#review-outcome)

## Purpose

Use this reference when a change introduces structure or safeguards beyond the direct feature edit.
Expand Down Expand Up @@ -57,6 +66,41 @@ Ask these questions during review:
An unclear answer is a reason to defer or narrow the addition, not proof that it is unnecessary.
Investigate high-impact correctness and security uncertainty before removing a safeguard.

## Migration and backward compatibility

Before adding migration code, compatibility shims, legacy formats, or upgrade
instructions, establish the transition that actually needs support:

- Which released behavior, persisted data, deployed configuration, external
caller, or user workflow must continue to work or move to the new state?
- What breaks under a direct change, and what evidence establishes the affected
consumers and the supported old-to-new boundary?
- Does that boundary need automated conversion, temporary compatibility, a
later user/operator action, or only a coordinated change within this task?

A rename, internal refactor, or new feature does not establish a migration
requirement by itself. When no supported old state or consumer needs a
transition, update the current implementation and its canonical documentation
without inventing legacy readers, version switches, upgrade machinery, or a
permanent migration guide. Keep transient implementation steps and migration
history in the PR when no later reader needs a procedure. Preserve rationale
needed to understand or maintain current behavior in canonical architecture
docs or nearby comments.

When a real transition exists, choose the smallest path that preserves the
required contract and data. Keep migration or compatibility support, focused
verification, and instructions for affected users/operators when they will need
them after the PR. A migration performed once by each installation can still
need lasting upgrade documentation. Use `domain-architecture-docs-workflow` to
choose the maintained document and audience; link rather than duplicate it in
the PR. Bound compatibility support to the supported versions or formats and
record a removal condition only when the support policy establishes one.

Unknown deployment, data, or caller state is a reason to investigate, not proof
that a direct breaking change or data reset is safe. Preserve existing migration
and recovery safeguards while investigating their consumers and retirement
conditions. Do not remove protection merely because it looks old or costly.

## Common review examples

| Situation | Proportionate change | Likely overengineering |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ runs:
- name: Set up reviewed APM CLI
uses: microsoft/apm-action@d723bb64ed70c135bbaf87d126b721dd2dae0439 # v1.10.0
with:
apm-version: "0.28.0"
apm-version: "0.35.0"
setup-only: "true"

- name: Audit APM deployment
shell: bash
run: apm audit --ci

- name: Lint Markdown source
uses: DavidAnson/markdownlint-cli2-action@21c1be1b93ad9ed58fa840aacc3f279cde2a72ff # v24.2.0
uses: DavidAnson/markdownlint-cli2-action@696eb3f2509270d7b882d2aa68347bc676e7af34 # v25.0.0
with:
config: .markdownlint-cli2.yaml
globs: "**/*.md"
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
uses: ./.github/actions/check-docker-source

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@bb05f3f5519dd87d3ba754cc423b652a5edd6d2c # v4.2.0
uses: docker/setup-buildx-action@f87e5991a6d7451dcb8d9637bfbc97413f497069 # v4.4.1

- name: Check Docker build configuration
uses: docker/build-push-action@53b7df96c91f9c12dcc8a07bcb9ccacbed38856a # v7.3.0
uses: docker/build-push-action@c3c9e263c25d99ce0380d002d59b67737d91b0dc # v7.4.0
with:
call: check
context: .
Expand All @@ -52,10 +52,10 @@ jobs:
persist-credentials: false

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@bb05f3f5519dd87d3ba754cc423b652a5edd6d2c # v4.2.0
uses: docker/setup-buildx-action@f87e5991a6d7451dcb8d9637bfbc97413f497069 # v4.4.1

- name: Build Docker image without publishing
uses: docker/build-push-action@53b7df96c91f9c12dcc8a07bcb9ccacbed38856a # v7.3.0
uses: docker/build-push-action@c3c9e263c25d99ce0380d002d59b67737d91b0dc # v7.4.0
with:
context: .
file: ./Dockerfile
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
uses: ./.github/actions/check-docker-source

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@bb05f3f5519dd87d3ba754cc423b652a5edd6d2c # v4.2.0
uses: docker/setup-buildx-action@f87e5991a6d7451dcb8d9637bfbc97413f497069 # v4.4.1

- name: Check Docker build configuration
uses: docker/build-push-action@53b7df96c91f9c12dcc8a07bcb9ccacbed38856a # v7.3.0
uses: docker/build-push-action@c3c9e263c25d99ce0380d002d59b67737d91b0dc # v7.4.0
with:
call: check
context: .
Expand Down
6 changes: 5 additions & 1 deletion .agents/skills/prose-quality-check/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

## Overview

Review explanatory prose for readability, local structure, and preserved nuance.
Review explanatory prose for readable structure, self-contained context, and preserved nuance.
Balance section, paragraph, sentence, and list size without fixed length limits.
Remove unnecessary time dependencies and make useful time boundaries explicit in durable documents.
Omit redundant qualifiers and unintended differences between parallel statements
while retaining distinctions readers need.

## Install

Expand Down
Loading