Skip to content

build(c): improve meson support on Windows - #4781

Open
taozuhong wants to merge 6 commits into
apache:mainfrom
taozuhong:meson
Open

taozuhong wants to merge 6 commits into
apache:mainfrom
taozuhong:meson

Conversation

@taozuhong

@taozuhong taozuhong commented Sep 12, 2026

Copy link
Copy Markdown

Fixed:

  1. Meson build issue like Link failed with libadbc_driver_framework.dll.a #4776
  2. Generate Vala vapi support

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a CI job that uses Meson + MinGW?

Comment thread glib/meson_options.txt
Comment thread c/driver_manager/meson.build Outdated
Comment thread c/driver_manager/meson.build Outdated
@taozuhong taozuhong changed the title Fixed meson compile issue Improve meson build support Sep 13, 2026
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@lidavidm lidavidm changed the title Improve meson build support build(c): improve meson support Sep 14, 2026
@lidavidm lidavidm changed the title build(c): improve meson support build(c): improve meson support on Windows Sep 14, 2026
@lidavidm

Copy link
Copy Markdown
Member

@taozuhong Why did you close this and open a new, identical PR?

@taozuhong

taozuhong commented Sep 15, 2026

Copy link
Copy Markdown
Author

Yeah, fixed and merged your comments, merge them into one commit action

@lidavidm

Copy link
Copy Markdown
Member

That's not necessary. We already squash on merge. The new PR lacks context, and it removes attribution for coauthors.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Windows-specific Meson fix needs Windows CI coverage for exports and system-library linkage.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Improves Windows Meson builds by exporting DLL symbols, linking required system libraries, and enabling Vala API generation.

Changes:

  • Adds Windows DLL export flags and required libraries.
  • Enables VAPI generation by default.
  • Fixes generated-header line endings and modernizes Meson path handling.
File summaries
File Description
c/meson.build Defines shared-library export arguments.
c/driver/common/meson.build Exports common-library symbols.
c/driver/framework/meson.build Exports framework symbols.
c/driver/sqlite/meson.build Exports SQLite driver symbols.
c/driver/postgresql/meson.build Adds exports and Winsock linkage.
c/driver_manager/meson.build Adds exports and Windows libraries.
glib/meson.build Uses the global source root.
glib/meson_options.txt Enables VAPI generation by default.
glib/tool/generate-version-header.py Forces LF-only generated headers.
Review details
  • Files reviewed: 9/9 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread c/meson.build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants