Conversation
kou
left a comment
There was a problem hiding this comment.
Can we add a CI job that uses Meson + MinGW?
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
@taozuhong Why did you close this and open a new, identical PR? |
|
Yeah, fixed and merged your comments, merge them into one commit action |
|
That's not necessary. We already squash on merge. The new PR lacks context, and it removes attribution for coauthors. |
There was a problem hiding this comment.
🟡 Changes recommended
The Windows-specific Meson fix needs Windows CI coverage for exports and system-library linkage.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Improves Windows Meson builds by exporting DLL symbols, linking required system libraries, and enabling Vala API generation.
Changes:
- Adds Windows DLL export flags and required libraries.
- Enables VAPI generation by default.
- Fixes generated-header line endings and modernizes Meson path handling.
File summaries
| File | Description |
|---|---|
c/meson.build |
Defines shared-library export arguments. |
c/driver/common/meson.build |
Exports common-library symbols. |
c/driver/framework/meson.build |
Exports framework symbols. |
c/driver/sqlite/meson.build |
Exports SQLite driver symbols. |
c/driver/postgresql/meson.build |
Adds exports and Winsock linkage. |
c/driver_manager/meson.build |
Adds exports and Windows libraries. |
glib/meson.build |
Uses the global source root. |
glib/meson_options.txt |
Enables VAPI generation by default. |
glib/tool/generate-version-header.py |
Forces LF-only generated headers. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fixed: