perf: zstd implement Pooling + DecodeAll with no new reader. - #1331
Draft
samueleresca wants to merge 1 commit into
Draft
samueleresca wants to merge 1 commit into
samueleresca wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Performance improvement on the zstd path.
What changes are included in this PR?
sync.Poolinstead of being created for every record batch, and each compressed buffer is decoded with oneDecodeAllcall straight into the destination buffer (decoder built withWithDecoderConcurrency(1)andWithDecodeAllCapLimit(true))instead ofReset(bytes.NewReader)+io.ReadFullon a streaming decoder.lz4.Reader; the library already pools its large block buffers internally. (Only a Decompress method wrapper was added.)Are these changes tested?
Added tests + benchmark for zstd (the changed path) - every case improves
Are there any user-facing changes?