Conversation
peterxcli
marked this pull request as ready for review
September 15, 2026 20:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11068.
A Parquet reader may restore dictionary-encoded
valueor primitivetyped_valuefields from an embedded Arrow schema.VariantArray::try_newrejects these inputs, so downstream callers must decode them recursively before constructing a Variant array.What changes are included in this PR?
Decode dictionary-encoded
valueand supported primitivetyped_valueinputs during Variant normalization, including nested shredding states. Keep the resulting storage canonical and attach UUID metadata after decoding UUID fields.The Variant specification permits dictionary encoding for
metadata; this change also accepts dictionary-encodedvalueand primitivetyped_valueinputs for compatibility, decoding them into canonical storage.Are these changes tested?
Tests cover all dictionary key types, logical and parent nulls, slices, nested fallback values, extraction, and unshredding. Variant tests, formatting, and Clippy pass with Rust 1.98.1.
Are there any user-facing changes?
Both Variant array constructors accept these encoded inputs. Decoding may allocate; run-end-encoded values remain unsupported.