Conversation
|
Merge up to get the fix for audit failure |
|
Thank you @blaginin -- I will be honest that this looks much more complicated than I was expecting Is there some reason not to just change MIRI to run on pushes to main and merge_queue? That way we would save them running on PRs. It would still run about 2x on each PR (though sometimes the merge_queue one could be shared) |
|
Thanks for the review. I was trying to copy the approach from comet:
specifically, stuff like this is a bit tricky:
|
|
i wonder if we should try simplifying our CI routing first; for example, group parquet-variant checks into just parquet, and fix some triggers for parquet (i see theres a trigger for any arrow-avro changes but i dont think theres actually a dependency in code for this?) i do agree this routing logic feels a bit heavy, especially given (as far as i understand) in comet its because they have a lot of heavy CI tasks so they need this granular dispatch, whilst for us here its mainly miri (and maybe the arrow integration) that are heavy
with datafusion, did it not have this routing logic in the first place (before merge queue was implemented there)? |

Add merge queue to arrow-rs and move miri to run there (and not on every push)