test(parquet): move scalar roundtrip tests - #11128
Open
Phoenix500526 wants to merge 4 commits into
Open
Phoenix500526 wants to merge 4 commits into
Phoenix500526 wants to merge 4 commits into
Conversation
Phoenix500526
force-pushed
the
consolidate-writer-roundtrip
branch
from
September 18, 2026 08:59
ad84c11 to
c63049e
Compare
Share the existing roundtrip harness so writer tests can move to integration tests in small batches without duplicating coverage. Refs apache#10540
Keep integer and float roundtrip coverage with the integration suite so related end-to-end tests are easier to find and extend. Refs apache#10540
Keep temporal roundtrip coverage with the writer integration suite so related tests are easier to find and extend. Refs apache#10540
Keep binary and string roundtrip coverage with the writer integration suite so related tests are easier to find and extend. Refs apache#10540
Phoenix500526
force-pushed
the
consolidate-writer-roundtrip
branch
from
September 19, 2026 01:16
c63049e to
5b60dea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10540.
Rationale for this change
Continue consolidating Arrow/Parquet roundtrip coverage in the writer integration suite so related end-to-end tests are easier to find and extend. Sharing the existing harness allows the tests to move in small batches while the remaining unit tests keep using the same validation logic.
What changes are included in this PR?
parquet/tests/arrow_writer/roundtrip.rs: 10 numeric, 14 temporal, and 7 binary/string tests.Are these changes tested?
cargo test --locked --offline -p parquet --lib arrow::arrow_writer::tests::: 106 passed.cargo test --locked --offline -p parquet --test arrow_writer: 58 passed.cargo test --locked --offline -p parquet --no-default-features --features arrow --test arrow_writer: 58 passed.cargo fmt --all --checkcargo clippy --locked --offline -p parquet --all-targets --all-features -- -D warningsThe affected writer suites still contain 164 tests in total: 137 + 27 before migration, 106 + 58 after migration.
Are there any user-facing changes?
No. This PR reorganizes tests only.