fix(build): clean up redundant warning sources#3385
Open
darion-yaphet wants to merge 2 commits into
Open
Conversation
Remove redundant pthread linkage from protoc-gen-mcpack targets and quiet compiler warnings from unused rpcz/couchbase code paths and non-x86 iobuf builds.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces build-time noise by removing redundant link dependencies and eliminating warning-producing but otherwise unused/legacy code paths in core brpc utilities and builtins.
Changes:
- Remove explicit
pthreadlinkage fromprotoc-gen-mcpackCMake targets (relying on existing thread linkage via common libraries). - Remove warning-only / unused code that triggered compiler diagnostics in rpcz and non-x86_64 iobuf fallback paths.
- Silence an unused Couchbase constant and fix file formatting (newline at EOF).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/CMakeLists.txt | Drops redundant pthread linkage from protoc-gen-mcpack targets. |
| src/butil/iobuf.cpp | Removes a non-x86_64 #warning to quiet builds. |
| src/brpc/couchbase.cpp | Marks an unused constant as unused and normalizes EOF newline. |
| src/brpc/builtin/rpcz_service.cpp | Removes an unused span-type string block to avoid unused-variable warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
48
to
50
| [[maybe_unused]] constexpr uint32_t APPLE_VBUCKET_COUNT = 64; | ||
| constexpr uint32_t DEFAULT_VBUCKET_COUNT = 1024; | ||
| [[maybe_unused]] constexpr uint32_t DEFAULT_VBUCKET_COUNT = 1024; | ||
| constexpr int CONNECTION_ID_SIZE = 33; |
Use brpc's existing ALLOW_UNUSED macro on Couchbase vbucket constants so the declarations keep silencing platform-specific unused-constant warnings without requiring C++17 attributes.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Remove redundant pthread linkage from protoc-gen-mcpack targets and quiet compiler warnings from unused rpcz/couchbase code paths and non-x86 iobuf builds.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
This PR cleans up redundant build configuration and compiler warning sources.
protoc-gen-mcpackalready links through the configured dynamic/static brpc target anddynamic libraries, so the explicit
pthreadlinkage is unnecessary. A few warning-only code paths also produced noise from unused rpcz/couchbase symbols and the non-x86 iobuf fallback warning.
What is changed and the side effects?
Changed:
pthreadlinkage fromprotoc-gen-mcpackCMake targets.span_type_strblock from rpcz annotation printing.DEFAULT_VBUCKET_COUNTas[[maybe_unused]].#warningfrom iobuf fallback code.src/brpc/couchbase.cppends with a newline.Side effects:
Check List: